-
Notifications
You must be signed in to change notification settings - Fork 13.4k
[beta] Comment out dev key in stage0.txt #60868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
While bumping to 1.34.2 should be fine, why are the 1.34.0 artifacts getting 404? |
@bors r+ p=20
The URLs on dev-static are different than the URLs on static. The 1.34.0 URLs are https://dev-static.rust-lang.org/dist/2019-04-08/channel-rust-stable.toml and https://static.rust-lang.org/dist/2019-04-11/channel-rust-stable.toml. |
📌 Commit 315287c has been approved by |
[beta] Comment out dev key in stage0.txt r? @pietroalbini We should maybe have some check for this somewhere; I think this is at least the second time we've forgotten to do this. Maybe just have CI fail on beta branch unless it's commented (and not a release week?)?
I see, that URL is the whole point of this dev key. Thanks! |
☀️ Test successful - checks-travis, status-appveyor |
r? @pietroalbini
We should maybe have some check for this somewhere; I think this is at least the second time we've forgotten to do this. Maybe just have CI fail on beta branch unless it's commented (and not a release week?)?