Skip to content

[beta] Comment out dev key in stage0.txt #60868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2019
Merged

[beta] Comment out dev key in stage0.txt #60868

merged 2 commits into from
May 16, 2019

Conversation

Mark-Simulacrum
Copy link
Member

r? @pietroalbini

We should maybe have some check for this somewhere; I think this is at least the second time we've forgotten to do this. Maybe just have CI fail on beta branch unless it's commented (and not a release week?)?

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 15, 2019
@rust-highfive
Copy link
Contributor

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:06:17] curl: (22) The requested URL returned error: 404 Not Found
[00:06:17] 
[00:06:17] spurious failure, trying again
[00:06:17] curl: (22) The requested URL returned error: 404 Not Found
[00:06:17] failed to run: curl -s -y 30 -Y 10 --connect-timeout 30 --retry 3 -Sf -o /tmp/tmpMJENtS.sha256 https://static.rust-lang.org/dist/2019-04-08/rust-std-1.34.0-x86_64-unknown-linux-gnu.tar.gz.sha256
[00:06:17] make: *** [prepare] Error 1
[00:06:17] Makefile:69: recipe for target 'prepare' failed
[00:06:18] Command failed. Attempt 2/5:
[00:06:18] curl: (22) The requested URL returned error: 404 Not Found
---
[00:06:19] curl: (22) The requested URL returned error: 404 Not Found
[00:06:19] 
[00:06:19] spurious failure, trying again
[00:06:19] curl: (22) The requested URL returned error: 404 Not Found
[00:06:19] failed to run: curl -s -y 30 -Y 10 --connect-timeout 30 --retry 3 -Sf -o /tmp/tmpT5_BSc.sha256 https://static.rust-lang.org/dist/2019-04-08/rust-std-1.34.0-x86_64-unknown-linux-gnu.tar.gz.sha256
[00:06:19] make: *** [prepare] Error 1
[00:06:19] Makefile:69: recipe for target 'prepare' failed
[00:06:21] Command failed. Attempt 3/5:
[00:06:22] curl: (22) The requested URL returned error: 404 Not Found
---
[00:06:22] curl: (22) The requested URL returned error: 404 Not Found
[00:06:22] 
[00:06:22] spurious failure, trying again
[00:06:23] curl: (22) The requested URL returned error: 404 Not Found
[00:06:23] failed to run: curl -s -y 30 -Y 10 --connect-timeout 30 --retry 3 -Sf -o /tmp/tmpjZXOD_.sha256 https://static.rust-lang.org/dist/2019-04-08/rust-std-1.34.0-x86_64-unknown-linux-gnu.tar.gz.sha256
[00:06:23] make: *** [prepare] Error 1
[00:06:23] Makefile:69: recipe for target 'prepare' failed
[00:06:26] Command failed. Attempt 4/5:
[00:06:26] curl: (22) The requested URL returned error: 404 Not Found
---
[00:06:26] curl: (22) The requested URL returned error: 404 Not Found
[00:06:26] 
[00:06:26] spurious failure, trying again
[00:06:26] curl: (22) The requested URL returned error: 404 Not Found
[00:06:26] failed to run: curl -s -y 30 -Y 10 --connect-timeout 30 --retry 3 -Sf -o /tmp/tmp4kPptN.sha256 https://static.rust-lang.org/dist/2019-04-08/rust-std-1.34.0-x86_64-unknown-linux-gnu.tar.gz.sha256
[00:06:26] make: *** [prepare] Error 1
[00:06:26] Makefile:69: recipe for target 'prepare' failed
[00:06:30] Command failed. Attempt 5/5:
[00:06:31] curl: (22) The requested URL returned error: 404 Not Found
---
[00:06:31] curl: (22) The requested URL returned error: 404 Not Found
[00:06:31] 
[00:06:31] spurious failure, trying again
[00:06:31] curl: (22) The requested URL returned error: 404 Not Found
[00:06:31] failed to run: curl -s -y 30 -Y 10 --connect-timeout 30 --retry 3 -Sf -o /tmp/tmpAwQaXJ.sha256 https://static.rust-lang.org/dist/2019-04-08/rust-std-1.34.0-x86_64-unknown-linux-gnu.tar.gz.sha256
[00:06:31] make: *** [prepare] Error 1
[00:06:31] Makefile:69: recipe for target 'prepare' failed
[00:06:31] The command has failed after 5 attempts.
travis_time:end:024fd660:start=1557964205440331231,finish=1557964597530787535,duration=392090456304
---
travis_time:end:0de1b1c8:start=1557964598512412440,finish=1557964598519530281,duration=7117841
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0d7df8ba
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0b3493eb
travis_time:start:0b3493eb
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:00a766e2
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@cuviper
Copy link
Member

cuviper commented May 16, 2019

While bumping to 1.34.2 should be fine, why are the 1.34.0 artifacts getting 404?

@pietroalbini
Copy link
Member

@bors r+ p=20

While bumping to 1.34.2 should be fine, why are the 1.34.0 artifacts getting 404?

The URLs on dev-static are different than the URLs on static. The 1.34.0 URLs are https://dev-static.rust-lang.org/dist/2019-04-08/channel-rust-stable.toml and https://static.rust-lang.org/dist/2019-04-11/channel-rust-stable.toml.

@bors
Copy link
Collaborator

bors commented May 16, 2019

📌 Commit 315287c has been approved by pietroalbini

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 16, 2019
@Mark-Simulacrum Mark-Simulacrum changed the title Comment out dev key in stage0.txt [beta] Comment out dev key in stage0.txt May 16, 2019
@bors
Copy link
Collaborator

bors commented May 16, 2019

⌛ Testing commit 315287c with merge d08ab31...

bors added a commit that referenced this pull request May 16, 2019
[beta] Comment out dev key in stage0.txt

r? @pietroalbini

We should maybe have some check for this somewhere; I think this is at least the second time we've forgotten to do this. Maybe just have CI fail on beta branch unless it's commented (and not a release week?)?
@cuviper
Copy link
Member

cuviper commented May 16, 2019

I see, that URL is the whole point of this dev key. Thanks!

@bors
Copy link
Collaborator

bors commented May 16, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: pietroalbini
Pushing d08ab31 to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 16, 2019
@bors bors merged commit 315287c into beta May 16, 2019
@dtolnay dtolnay deleted the fix-dev-no-comment branch October 27, 2019 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants