Fixes primitive sidebar link generation #55682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
Ping from triage: @QuietMisdreavus have you had time to review this PR? |
|
Can you add a test? You can cause the linked issue by giving a struct two functions with the same name: pub struct SomeStruct<T> { _inner: T }
impl SomeStruct<()> {
pub fn some_fn(&self) {}
}
impl SomeStruct<usize> {
pub fn some_fn(&self) {}
} |
|
Ok! |
GuillaumeGomez
force-pushed
the
primitive-sidebar-link-gen
branch
from
6720870 to
c746ecf
Compare
|
Added the test. |
|
Ping from triage @QuietMisdreavus: This PR requires your review. |
|
Thanks! @bors r+ |
|
📌 Commit c746ecf has been approved by |
bors
added
S-waiting-on-bors
|
(Dunno how i closed the PR, but that wasn't supposed to happen...) |
bors
added a commit
that referenced
this pull request
Dec 4, 2018
…uietMisdreavus Fixes primitive sidebar link generation Fixes #50746. Fixes #55656. r? @QuietMisdreavus
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50746.
Fixes #55656.
r? @QuietMisdreavus