Skip to content

Enable NLL compare mode for more tests #54622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2018

Conversation

matthewjasper
Copy link
Contributor

Most of these tests were disabled due to NLL bugs that have since been fixed. A few needed updating for NLL.

r? @nikomatsakis

These tests were disabled due to NLL bugs that have since been fixed.
@matthewjasper matthewjasper added the A-NLL Area: Non-lexical lifetimes (NLL) label Sep 27, 2018
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 27, 2018
@pnkfelix
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 27, 2018

📌 Commit 27ea811 has been approved by pnkfelix

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2018
@bors
Copy link
Collaborator

bors commented Sep 30, 2018

⌛ Testing commit 27ea811 with merge 53c5e73bcbe8ae3cc40710853547f689f30b4bae...

@bors
Copy link
Collaborator

bors commented Sep 30, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 30, 2018
@rust-highfive
Copy link
Contributor

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
Attempting to download s3://rust-lang-ci-sccache2/docker/8cb17e7c7c0f6907c425b4c50d08e1a7be31e220c3f9037c48f787ad01ebd83a92516c697c997c632d5bed194c4314351a1e98d09c16b3acfab331232abd8748
[00:00:58] Attempting with retry: curl -f -L -C - -o /tmp/rustci_docker_cache https://s3-us-west-1.amazonaws.com/rust-lang-ci-sccache2/docker/8cb17e7c7c0f6907c425b4c50d08e1a7be31e220c3f9037c48f787ad01ebd83a92516c697c997c632d5bed194c4314351a1e98d09c16b3acfab331232abd8748
[00:00:58]   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
[00:00:58]                                  Dload  Upload   Total   Spent    Left  Speed
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@kennytm
Copy link
Member

kennytm commented Sep 30, 2018

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 30, 2018
@bors
Copy link
Collaborator

bors commented Sep 30, 2018

⌛ Testing commit 27ea811 with merge 3905409...

bors added a commit that referenced this pull request Sep 30, 2018
Enable NLL compare mode for more tests

Most of these tests were disabled due to NLL bugs that have since been fixed. A few needed updating for NLL.

r? @nikomatsakis
@bors
Copy link
Collaborator

bors commented Sep 30, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: pnkfelix
Pushing 3905409 to master...

@bors bors merged commit 27ea811 into rust-lang:master Sep 30, 2018
@matthewjasper matthewjasper deleted the more-nll-mode branch October 13, 2018 20:57
@matthewjasper matthewjasper restored the more-nll-mode branch October 13, 2018 20:58
@matthewjasper matthewjasper deleted the more-nll-mode branch November 30, 2018 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-NLL Area: Non-lexical lifetimes (NLL) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants