Skip to content

Window Mutex: Document that we properly initialize the SRWLock #53311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 24, 2018
Merged

Window Mutex: Document that we properly initialize the SRWLock #53311

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a72954
Window Mutex: make sure we properly initialize the SRWLock
RalfJung Aug 13, 2018
b7a49e7
fixed wording
RalfJung Aug 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/libstd/sys/windows/mutex.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ pub unsafe fn raw(m: &Mutex) -> c::PSRWLOCK {
impl Mutex {
pub const fn new() -> Mutex {
Mutex {
// This works because SRWLOCK_INIT is a NULL pointer, so we are also properly
Copy link
Member

@retep998 retep998 Aug 14, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically SRWLOCK is a struct wrapping a pointer which isn't actually used as a pointer, so SRWLOCK_INIT is zero initializing a struct.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow. I guess Windows API doesn't really care about meaningful types?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, I hope.

// initializing an SRWLOCK here.
lock: AtomicUsize::new(0),
held: UnsafeCell::new(false),
}
Expand Down