libsyntax: small refactorings #51945
Conversation
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
| if self.token == *ket { | ||
| self.bump(); | ||
| } | ||
| self.eat(ket); |
There was a problem hiding this comment.
This should change diagnostics by adding ket to the expected set, but it looks like a desirable change in this case.
| @@ -365,6 +365,10 @@ impl Token { | |||
| self == &Lt || self == &BinOp(Shl) | |||
| } | |||
|
|
|||
| crate fn is_args_start(&self) -> bool { | |||
| self.is_qpath_start() || self == &OpenDelim(Paren) | |||
There was a problem hiding this comment.
Well, the tokens technically coincide with the is_qpath_start set, but </<< in Type<T>/Type<<X as Y>::Assoc> is not a qpath start at all.
I'd remove this commit.
| }, | ||
| _ => None, | ||
| }; | ||
| if let Some(path) = meta_ident { |
There was a problem hiding this comment.
Outlining a small function that's used only once doesn't look like a good style to me.
I'd remove this commit.
|
Thanks! |
petrochenkov
added
S-waiting-on-author
|
Triage; @topecongiro is there any update on this? |
|
Ping from triage, @topecongiro it has been a while since the last time we heard from you, is there any update on this PR? |
|
Thank you for this PR @topecongiro! Unfortunately we haven't heard from you on this in a while, so I'm closing the PR to keep things tidy. Don't worry though, if you'll have time again in the future please reopen this PR, we'll be happy to review it again! |
pietroalbini
added
S-inactive
Replace check() + bump() with eat() cc #51945. r? @petrochenkov
This PR consists of small refactorings to libsyntax.