Skip to content

Remove erroneous example of main as a non-Result function. #51644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2018
Merged

Remove erroneous example of main as a non-Result function. #51644

merged 1 commit into from
Jun 20, 2018

Conversation

Sgeo
Copy link
Contributor

@Sgeo Sgeo commented Jun 19, 2018

No description provided.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 19, 2018
@hanna-kruppe
Copy link
Contributor

Thank you!

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 19, 2018

📌 Commit 0b9c686 has been approved by rkruppe

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 19, 2018
@hanna-kruppe
Copy link
Contributor

@bors rollup

@bors
Copy link
Collaborator

bors commented Jun 20, 2018

⌛ Testing commit 0b9c686 with merge cca43a7...

bors added a commit that referenced this pull request Jun 20, 2018
@bors
Auto merge of #51644 - Sgeo:patch-1, r=rkruppe
cca43a7 
Remove erroneous example of main as a non-Result function.
@bors
Copy link
Collaborator

bors commented Jun 20, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: rkruppe
Pushing cca43a7 to master...

@bors bors merged commit 0b9c686 into rust-lang:master Jun 20, 2018
@frewsxcv frewsxcv mentioned this pull request Jun 20, 2018
Closed
@Sgeo Sgeo deleted the patch-1 branch June 23, 2018 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joshtriplett joshtriplett

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Sgeo @rust-highfive @hanna-kruppe @bors @joshtriplett