Add AdHocCalls and pass self to build_controller as Box<Self> #50844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
r? @nrc |
nrc
reviewed
May 17, 2018
src/librustc_driver/lib.rs
Outdated
| #[derive(Copy, Clone)] | ||
| pub struct RustcDefaultCalls; | ||
|
|
||
| pub enum AdHocCalls<'a> { |
There was a problem hiding this comment.
Could you document AdHocCalls please? It's not exactly clear to me what it does - is it purely a convenience to avoid implementing build_controller?
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bjorn3
force-pushed
the
adhoc_compiller_calls
branch
from
4c10382 to
bfca4aa
Compare
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bjorn3
force-pushed
the
adhoc_compiller_calls
branch
from
bfca4aa to
f9b082d
Compare
|
Travis is green |
|
Ping @nrc |
nrc
reviewed
May 27, 2018
src/librustc_driver/lib.rs
Outdated
| #[derive(Copy, Clone)] | ||
| pub struct RustcDefaultCalls; | ||
|
|
||
| /// CompilerCalls instance for quick access to the result of one compile phase. | ||
| pub enum AdHocCalls<'a> { |
There was a problem hiding this comment.
Why is this an enum rather than a struct?
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
What happened there? |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bjorn3
force-pushed
the
adhoc_compiller_calls
branch
from
287bfc8 to
3086800
Compare
|
Ping from triage, @nrc ! |
nrc
reviewed
Jun 4, 2018
src/librustc_driver/driver.rs
Outdated
| @@ -414,6 +414,63 @@ impl<'a> CompileController<'a> { | |||
| } | |||
| } | |||
|
|
|||
| impl<'a> ::CompilerCalls<'a> for CompileController<'a> { | |||
There was a problem hiding this comment.
Could you document this please? Why is this impl significant how should clients who are making a new controller do things?
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@bors: r+ |
|
📌 Commit e9b4c53 has been approved by |
bors
added
S-waiting-on-bors
|
@bors r=nrc |
|
📌 Commit cc5c1a0 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jun 5, 2018
Add AdHocCalls and pass self to build_controller as Box<Self> This makes it easier to write custom drivers.
|
💔 Test failed - status-travis |
bors
added
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
1 similar comment
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@bors retry - timeout |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jun 5, 2018
Add AdHocCalls and pass self to build_controller as Box<Self> This makes it easier to write custom drivers.
|
💥 Test timed out |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jun 6, 2018
Add AdHocCalls and pass self to build_controller as Box<Self> This makes it easier to write custom drivers.
|
☀️ Test successful - status-appveyor, status-travis |
|
📣 Toolstate changed by #50844! Tested on commit 685faa2. 💔 miri on windows: test-pass → build-fail (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra). |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Jun 6, 2018
Tested on commit rust-lang/rust@685faa2. Direct link to PR: <rust-lang/rust#50844> 💔 miri on windows: test-pass → build-fail (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra). 💔 miri on linux: test-pass → build-fail (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra). 💔 rls on windows: test-pass → build-fail (cc @nrc, @rust-lang/infra). 💔 rls on linux: test-pass → build-fail (cc @nrc, @rust-lang/infra).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to write custom drivers.