auto: librustc: Stop exporting all cross-crate inlined functions. Shaves 800K off librustc. #4883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function that formats and prints the squigly line that hilights errors counted tabs as spaces, which resulted in incorrect error messages when tabs were used for indentation. This change compares the highlight line with the previous line and inserts a tab instead of a space whenever such a tab exists on the previous line. Note that error messages will still highlight incorrectly when the previous line include characters that require more than one utf8 code point, as mentioned in issue 3260.
…ter_task/unregister_task. Closes rust-lang#4768
A simple fix for issue 2174.
It seems to me the library needs more work to be done, but having a non-compilable sample program seems like bad news.
If an enum is isomorphic to unit, there's no need to use any bits to represent it. The only obvious reason this wasn't the case was because the enum could be C-like and have a user-specified discriminant -- but that value is constant, so it doesn't need to be stored. This change means that all newtype-like enums have the same size (and layout) as their underlying type, which might be a useful property to have, at least in terms of making programs' low-level behavior less surprising.
If an enum is isomorphic to unit, there's no need to use any bits to represent it. The only obvious reason this wasn't the case was because the enum could be C-like and have a user-specified discriminant -- but that value is constant, so it doesn't need to be stored. This change means that all newtype-like enums have the same size (and layout) as their underlying type, which might be a useful property to have, at least in terms of making programs' low-level behavior less surprising.
Without this change, rust-mode doesn't work if 'cl hasn't been required by something else, apparently. I'm not entirely sure what changed such that I started seeing this problem instead of not, but maybe the emacs world has been making progress towards not loading 'cl at runtime if it's only needed at compile time.
- thanks to work in libuv's upstream, we can call libuv's Makefile directly with parameters, instead of descending in gyp-uv madness and generating our own.
…d libuv work on mingw
rust-mode.el uses the 'cl macros, so it should actually require them
…rno (unix) and GetLastError (windows).
This reverts commit a8f039a.
r? @nikomatsakis When you made the change to fix kinds in recursion, you stopped looking in the master cache. This patch fixes it.
and then adjust code to match. rs=unsound (will review post-landing)
…tsakis and then adjust code to match. rs=unsound (will review post-landing) rs=unsound
Rewrote the last pull request (rust-lang#4859) to not require on llvm for core. Also fixes rust-lang#2269.
…0K off librustc. r=graydon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @graydon