Skip to content

don't mention tasks in stability warnings of #[thread_local] #47755 #47800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2018
Merged

don't mention tasks in stability warnings of #[thread_local] #47755 #47800

merged 1 commit into from
Jan 28, 2018

Conversation

Pulkit07
Copy link
Contributor

This is a fix for issue #47755.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eddyb (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@kennytm
Copy link
Member

kennytm commented Jan 27, 2018

r? @sfackler

@rust-highfive rust-highfive assigned sfackler and unassigned eddyb Jan 27, 2018
@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 27, 2018
@sfackler
Copy link
Member

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 27, 2018

📌 Commit 5ce2b02 has been approved by sfackler

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2018
@bors
Copy link
Collaborator

bors commented Jan 28, 2018

⌛ Testing commit 5ce2b02 with merge 771873c...

bors added a commit that referenced this pull request Jan 28, 2018
@bors
Auto merge of #47800 - Pulkit07:issue47755, r=sfackler
771873c 
don't mention tasks in stability warnings of #[thread_local] #47755

This is a fix for issue #47755.
@bors
Copy link
Collaborator

bors commented Jan 28, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: sfackler
Pushing 771873c to master...

@bors bors merged commit 5ce2b02 into rust-lang:master Jan 28, 2018
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jan 28, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sfackler sfackler

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Pulkit07 @rust-highfive @kennytm @sfackler @bors @eddyb