Skip to content

Correctly bubble up errors from libbacktrace #44525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2017

Conversation

aidanhs
Copy link
Member

@aidanhs aidanhs commented Sep 12, 2017

Previously the first part of this code didn't check for a null pointer and blindly passed it back down, causing a segfault if libbacktrace failed to initialise. I've changed this to check and bubble up the error if relevant.

Suggested diff view: https://github.com/rust-lang/rust/pull/44525/files?w=1

@rust-highfive
Copy link
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@aidanhs aidanhs added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 13, 2017
@carols10cents
Copy link
Member

review ping @aturon, pinging you on irc too!!

@alexcrichton
Copy link
Member

@bors: r+

Thanks @aidanhs!

@bors
Copy link
Collaborator

bors commented Sep 19, 2017

📌 Commit 15887d7 has been approved by alexcrichton

@arielb1 arielb1 added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2017
@bors
Copy link
Collaborator

bors commented Sep 20, 2017

⌛ Testing commit 15887d7 with merge 01c65cb...

bors added a commit that referenced this pull request Sep 20, 2017
Correctly bubble up errors from libbacktrace

Previously the first part of this code didn't check for a null pointer and blindly passed it back down, causing a segfault if libbacktrace failed to initialise. I've changed this to check and bubble up the error if relevant.

Suggested diff view: https://github.com/rust-lang/rust/pull/44525/files?w=1
@bors
Copy link
Collaborator

bors commented Sep 20, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 01c65cb to master...

@bors bors merged commit 15887d7 into rust-lang:master Sep 20, 2017
@aidanhs aidanhs deleted the aphs-no-null-deref branch September 20, 2017 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants