Don't assume plugin-whitelisted attributes are proc macro attributes #40039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @jseyfried |
|
Excellent, thanks! |
|
📌 Commit 0bf59b5 has been approved by |
jseyfried
reviewed
Feb 22, 2017
src/librustc_resolve/macros.rs
Outdated
| @@ -181,6 +181,11 @@ impl<'a> base::Resolver for Resolver<'a> { | |||
| fn find_legacy_attr_invoc(&mut self, attrs: &mut Vec<ast::Attribute>) | |||
| -> Option<ast::Attribute> { | |||
| for i in 0..attrs.len() { | |||
| if self.session.plugin_attributes.borrow().iter() | |||
| .any(|&(ref attr_nm, _)| attrs[i].check_name(attr_nm)) { | |||
There was a problem hiding this comment.
check_name marks the attribute as used when it returns true, which is breaking plugin-attr-register-deny.rs on Travis.
I would use attrs[i].name() == attr_nm instead.
|
✌️ @abonander can now approve this pull request |
abonander
force-pushed
the
issue_40001
branch
from
0bf59b5 to
e5d4585
Compare
abonander
force-pushed
the
issue_40001
branch
from
b158944 to
dac25e2
Compare
|
@bors r=jseyfried |
|
📌 Commit dac25e2 has been approved by |
|
@Manishearth Could this get a p=1? |
|
@bors p=1 |
bors
added a commit
that referenced
this pull request
Feb 23, 2017
Don't assume plugin-whitelisted attributes are proc macro attributes closes #40001
|
☀️ Test successful - status-appveyor, status-travis |
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Feb 24, 2017
Make #[dom_struct] a proc_macro attribute The rustup is needed for rust-lang/rust#40039. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15715) <!-- Reviewable:end -->
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 25, 2017
… nox:custom-derive); r=SimonSapin The rustup is needed for rust-lang/rust#40039. Source-Repo: https://github.com/servo/servo Source-Revision: a204c4176dcccdad8ec99d74055c66794c3f64ba --HG-- rename : servo/components/domobject_derive/Cargo.toml => servo/components/dom_struct/Cargo.toml extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear extra : subtree_revision : 2cad140c3d6b99837f0bd15a6f3ccba0f353e049
JerryShih
pushed a commit
to JerryShih/gecko-dev
that referenced
this pull request
Mar 1, 2017
… nox:custom-derive); r=SimonSapin The rustup is needed for rust-lang/rust#40039. Source-Repo: https://github.com/servo/servo Source-Revision: a204c4176dcccdad8ec99d74055c66794c3f64ba
Manishearth
pushed a commit
to Manishearth/gecko-dev
that referenced
this pull request
Mar 9, 2017
… nox:custom-derive); r=SimonSapin The rustup is needed for rust-lang/rust#40039. Source-Repo: https://github.com/servo/servo Source-Revision: a204c4176dcccdad8ec99d74055c66794c3f64ba
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 1, 2019
… nox:custom-derive); r=SimonSapin The rustup is needed for rust-lang/rust#40039. Source-Repo: https://github.com/servo/servo Source-Revision: a204c4176dcccdad8ec99d74055c66794c3f64ba UltraBlame original commit: b439aae221f2298caa3f41781ce3dfbd0b36d8ad
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 1, 2019
… nox:custom-derive); r=SimonSapin The rustup is needed for rust-lang/rust#40039. Source-Repo: https://github.com/servo/servo Source-Revision: a204c4176dcccdad8ec99d74055c66794c3f64ba UltraBlame original commit: b439aae221f2298caa3f41781ce3dfbd0b36d8ad
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 1, 2019
… nox:custom-derive); r=SimonSapin The rustup is needed for rust-lang/rust#40039. Source-Repo: https://github.com/servo/servo Source-Revision: a204c4176dcccdad8ec99d74055c66794c3f64ba UltraBlame original commit: b439aae221f2298caa3f41781ce3dfbd0b36d8ad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #40001