Skip to content

Remove useless doc comment for slice #34723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2016
Merged

Remove useless doc comment for slice #34723

merged 1 commit into from
Jul 10, 2016

Conversation

GuillaumeGomez
Copy link
Member

r? @steveklabnik

This doc comment isn't useful so I removed it. It also "fixes" the weird rustdoc output.

Before:

screenshot from 2016-07-08 02-04-59

After:

screenshot from 2016-07-08 02-05-31

@apasel422
Copy link
Contributor

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 8, 2016

📌 Commit a5be0d2 has been approved by apasel422

@bors
Copy link
Collaborator

bors commented Jul 10, 2016

⌛ Testing commit a5be0d2 with merge 4d50e47...

bors added a commit that referenced this pull request Jul 10, 2016
@bors
Auto merge of #34723 - GuillaumeGomez:slice_doc, r=apasel422
4d50e47 
Remove useless doc comment for slice

r? @steveklabnik

This doc comment isn't useful so I removed it. It also "fixes" the weird rustdoc output.

Before:

![screenshot from 2016-07-08 02-04-59](https://cloud.githubusercontent.com/assets/3050060/16688164/fbb321d6-451c-11e6-8d98-53346bc6eb1e.png)

After:

![screenshot from 2016-07-08 02-05-31](https://cloud.githubusercontent.com/assets/3050060/16688166/00b174e4-451d-11e6-83dd-93ab2509f647.png)
@bors
Copy link
Collaborator

bors commented Jul 10, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild
Approved by: apasel422
Pushing 4d50e47 to master...

@bors bors merged commit a5be0d2 into rust-lang:master Jul 10, 2016
@GuillaumeGomez GuillaumeGomez deleted the slice_doc branch July 12, 2016 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GuillaumeGomez @apasel422 @bors @steveklabnik