Skip to content

Add test case for issue #23477 #34243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 14, 2016
Merged

Conversation

c3st7n
Copy link
Contributor

@c3st7n c3st7n commented Jun 12, 2016

My first pull request, any feedback welcome.

Fixes #23477

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@c3st7n c3st7n changed the title Add test case for issue 23477 Add test case for issue #23477 Jun 12, 2016

#![crate_type = "lib"]

extern crate core;
Copy link
Member

@nagisa nagisa Jun 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think you need core for this test anymore.

@nagisa
Copy link
Member

nagisa commented Jun 13, 2016

r=me with import of libcore removed and test move from debuginfo to run-pass/fail as appropriate.

@c3st7n
Copy link
Contributor Author

c3st7n commented Jun 13, 2016

I have moved the test to the run-pass directory, set to use compiler-flags and changed from a lib to a bin - test passes.

@c3st7n
Copy link
Contributor Author

c3st7n commented Jun 13, 2016

r=nagisa

@luqmana
Copy link
Member

luqmana commented Jun 13, 2016

@bors: r=nagisa

Thanks!

@bors
Copy link
Collaborator

bors commented Jun 13, 2016

📌 Commit d991b1f has been approved by nagisa

@bors
Copy link
Collaborator

bors commented Jun 13, 2016

⌛ Testing commit d991b1f with merge ab0b874...

bors added a commit that referenced this pull request Jun 13, 2016
Add test case for issue #23477

My first pull request, any feedback welcome.

Fixes #23477
@bors bors merged commit d991b1f into rust-lang:master Jun 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants