always make at least one codegen-unit #33732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows us to remove the dummy `foo` fn
| @@ -228,6 +228,17 @@ fn place_root_translation_items<'a, 'tcx, I>(tcx: TyCtxt<'a, 'tcx, 'tcx>, | |||
| } | |||
| } | |||
|
|
|||
| // always ensure we have at least one CGO; otherwise, if we have a | |||
|
I have something to that effect in my collector-driven trans branch too, where I ran into a similar problem. r=me with the typo fixed. |
|
@bors r=mw |
|
📌 Commit be7b576 has been approved by |
bors
added a commit
that referenced
this pull request
May 25, 2016
always make at least one codegen-unit this allows us to remove the dummy `foo` fn r? @michaelwoerister
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows us to remove the dummy
foofnr? @michaelwoerister