doc: that line was too long #33142
Merged
doc: that line was too long #33142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| /// the lock is left unspecified, however, this function will not return on | ||
| /// the second call, it might e.g. panic or deadlock. | ||
| /// the lock is left unspecified. However, this function will not return on | ||
| /// the second call. It might panic or deadlock, for example. |
There was a problem hiding this comment.
For the first interruption, I agree. However, the second makes the sentence less comfortable to read.
There was a problem hiding this comment.
@GuillaumeGomez Maybe I put the last sentence in brackets?
There was a problem hiding this comment.
I'm not sure to see what you propose. So do it and we'll see. :)
There was a problem hiding this comment.
However, this function will not return on the second call (it might panic or deadlock, for example).
There was a problem hiding this comment.
Oh great! I approve this one.
|
@GuillaumeGomez done |
|
Thanks! r=me @steveklabnik |
|
@bors: r=guillaumegomez |
|
📌 Commit 7609c64 has been approved by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.