Skip to content

Enable vfp3-d16 for ARMv7 Android target #33115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2016
Merged

Enable vfp3-d16 for ARMv7 Android target #33115

merged 1 commit into from
Apr 25, 2016

Conversation

mbrubeck
Copy link
Contributor

Android's armeabi-v7a ABI guarantees at least VFPv3-d16 hardware FPU support, so Rust should include this in the default features for the arm-linux-androideabi target.

@mbrubeck
Enable vfp3-d16 for ARMv7 Android target
4d7b930 
Android's [armeabi-v7a ABI][1] guarantees at least VFPv3-d16 hardware FPU
support, so Rust should include this in the default features for the
arm-linux-androideabi target.

[1]: https://developer.android.com/ndk/guides/abis.html
@rust-highfive
Copy link
Contributor

r? @nrc

(rust_highfive has picked a reviewer for you, use r? to override)

@mbrubeck mbrubeck mentioned this pull request Apr 20, 2016
Merged
@nrc
Copy link
Member

nrc commented Apr 20, 2016

@bors: r+

@bors
Copy link
Collaborator

bors commented Apr 20, 2016

📌 Commit 4d7b930 has been approved by nrc

@bors
Copy link
Collaborator

bors commented Apr 22, 2016

⌛ Testing commit 4d7b930 with merge 3d7145e...

@bors
Copy link
Collaborator

bors commented Apr 22, 2016

💔 Test failed - auto-win-msvc-64-opt-mir

@alexcrichton
Copy link
Member

@bors: retry

On Fri, Apr 22, 2016 at 8:33 AM, bors [email protected] wrote:

[image: 💔] Test failed - auto-win-msvc-64-opt-mir
http://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt-mir/builds/407

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#33115 (comment)

@bors
Copy link
Collaborator

bors commented Apr 23, 2016

⌛ Testing commit 4d7b930 with merge 7a7e541...

@bors
Copy link
Collaborator

bors commented Apr 23, 2016

💔 Test failed - auto-win-msvc-32-opt

@alexcrichton
Copy link
Member

@bors: retry

On Sat, Apr 23, 2016 at 11:06 AM, bors [email protected] wrote:

[image: 💔] Test failed - auto-win-msvc-32-opt
http://buildbot.rust-lang.org/builders/auto-win-msvc-32-opt/builds/3131

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#33115 (comment)

@bors
Copy link
Collaborator

bors commented Apr 23, 2016

⌛ Testing commit 4d7b930 with merge bc6b203...

@bors
Copy link
Collaborator

bors commented Apr 23, 2016

💔 Test failed - auto-win-msvc-32-opt

@alexcrichton
Copy link
Member

@bors: retry

On Saturday, April 23, 2016, bors [email protected] wrote:

[image: 💔] Test failed - auto-win-msvc-32-opt
http://buildbot.rust-lang.org/builders/auto-win-msvc-32-opt/builds/3133

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#33115 (comment)

@bors
Copy link
Collaborator

bors commented Apr 24, 2016

⌛ Testing commit 4d7b930 with merge 5261cd8...

@bors
Copy link
Collaborator

bors commented Apr 24, 2016

💔 Test failed - auto-win-msvc-32-opt

@alexcrichton
Copy link
Member

@bors: retry

On Sat, Apr 23, 2016 at 10:25 PM, bors [email protected] wrote:

[image: 💔] Test failed - auto-win-msvc-32-opt
http://buildbot.rust-lang.org/builders/auto-win-msvc-32-opt/builds/3139

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#33115 (comment)

@bors
Copy link
Collaborator

bors commented Apr 24, 2016

⌛ Testing commit 4d7b930 with merge e6aa77d...

@bors
Copy link
Collaborator

bors commented Apr 24, 2016

💔 Test failed - auto-win-gnu-32-opt-rustbuild

@alexcrichton
Copy link
Member

@bors: retry

On Sun, Apr 24, 2016 at 1:54 AM, bors [email protected] wrote:

[image: 💔] Test failed - auto-win-gnu-32-opt-rustbuild
http://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt-rustbuild/builds/841

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#33115 (comment)

@bors
Copy link
Collaborator

bors commented Apr 24, 2016

⌛ Testing commit 4d7b930 with merge 8324db2...

@bors
Copy link
Collaborator

bors commented Apr 25, 2016

💔 Test failed - auto-linux-64-cargotest

@alexcrichton
Copy link
Member

@bors: retry

On Sun, Apr 24, 2016 at 5:04 PM, bors [email protected] wrote:

[image: 💔] Test failed - auto-linux-64-cargotest
http://buildbot.rust-lang.org/builders/auto-linux-64-cargotest/builds/224

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#33115 (comment)

@bors
Copy link
Collaborator

bors commented Apr 25, 2016

⌛ Testing commit 4d7b930 with merge c110e31...

bors added a commit that referenced this pull request Apr 25, 2016
@bors
Auto merge of #33115 - mbrubeck:vfp3-d16, r=nrc
c110e31 
Enable vfp3-d16 for ARMv7 Android target

Android's [armeabi-v7a ABI][1] guarantees at least VFPv3-d16 hardware FPU support, so Rust should include this in the default features for the `arm-linux-androideabi` target.

[1]: https://developer.android.com/ndk/guides/abis.html
@bors
Copy link
Collaborator

bors commented Apr 25, 2016

💔 Test failed - auto-win-gnu-32-opt

@Manishearth
Copy link
Member

@bors retry

@bors
Copy link
Collaborator

bors commented Apr 25, 2016

⌛ Testing commit 4d7b930 with merge bd93816...

bors added a commit that referenced this pull request Apr 25, 2016
@bors
Auto merge of #33115 - mbrubeck:vfp3-d16, r=nrc
bd93816 
Enable vfp3-d16 for ARMv7 Android target

Android's [armeabi-v7a ABI][1] guarantees at least VFPv3-d16 hardware FPU support, so Rust should include this in the default features for the `arm-linux-androideabi` target.

[1]: https://developer.android.com/ndk/guides/abis.html
@bors
Copy link
Collaborator

bors commented Apr 25, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-32cross-opt, auto-linux-64-cargotest, auto-linux-64-cross-armhf, auto-linux-64-cross-armsf, auto-linux-64-cross-freebsd, auto-linux-64-cross-netbsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-cross-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild

@bors bors merged commit 4d7b930 into rust-lang:master Apr 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nrc nrc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mbrubeck @rust-highfive @nrc @bors @alexcrichton @Manishearth