-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Extends rustdoc on how to caputure output #32338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8d61cb2
Extends rustdoc on how to caputure output
lukaspustina 3b5cfa3
Tags new test as `no_run` and uses expect()
lukaspustina aefbbc7
Revert "Tags new test as `no_run` and uses expect()"
lukaspustina 4551794
Fixes 2. stdout to stderr in rustdoc
lukaspustina 0dd5f67
Adjusts all rust doc test to use `expect` and `should_panic`
lukaspustina 5613372
Fixes test which are now run due to should_panic
lukaspustina File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you tag this as
no_run
? I don't think Windows has/bin/cat
programsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checking with you: The example for
output
also only runs on windows and is also not tagged.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right because this'll just panic anyway as it couldn't spawn a process. Either way's fine!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexcrichton I prefer consistency, so let me revert my last commit so the PR reflects the initial doc update for
std::process::Child::wait_with_output()
. I'll create another PR to for the discussed changes.