Remove alternate stack with sigaltstack before unmaping it. #31684
Conversation
| Handler { _data: stack.ss_sp as *mut libc::c_void } | ||
| let mut stack = mem::zeroed(); | ||
| sigaltstack(ptr::null(), &mut stack); | ||
| if stack.ss_flags & SS_DISABLE != 0 { |
There was a problem hiding this comment.
Could you add a comment explaining what this check is doing? I think it's just checking to see if one's already set, right?
|
Thanks @tmiasko! |
|
I have added comment before checking for SS_DISABLE, |
|
@bors: r+ 4022ff164884a4628ac9498c9d9557cca643c8bb |
|
⌛ Testing commit 4022ff1 with merge ec445e3... |
|
💔 Test failed - auto-mac-64-opt |
Also reuse existing signal stack if already set, this is especially useful when working with sanitizers that configure alternate stack themselves.
|
The buildbot test failure on Mac OS is real. While I don't have Mac to test I incorporated a workaround that passes SIGSTKSZ when disabling the stack. |
Remove alternate stack with sigaltstack before unmaping it. Also reuse existing signal stack if already set, this is especially useful when working with sanitizers that configure alternate stack themselves. This change depends on SS_DISABLE recently introduced in libc crate and updates this git submodule accordingly.
ghost
deleted the
Remove alternate stack with sigaltstack before unmaping it.
Also reuse existing signal stack if already set, this is especially
useful when working with sanitizers that configure alternate stack
themselves.
This change depends on SS_DISABLE recently introduced in libc crate and updates
this git submodule accordingly.