-
Notifications
You must be signed in to change notification settings - Fork 13.4k
[docs] Update references and borrowing (Fixes #29730) #29805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@bors: r+ rollup thanks so much! |
📌 Commit 7b9b9df has been approved by |
💔 Test failed - auto-mac-64-nopt-t |
lol how even does this fail. Is it the warnings that cause this? I've noticed that sometimes pull requests by people fail and you guys just retry. Is this something that would be worth taking a look at (by me)? |
@bors: retry |
@norcalli I think it's just a transient error |
Fixes #29730