Skip to content

std: Remove the curious inner module #27388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2015

Conversation

alexcrichton
Copy link
Member

This isn't actually necessary any more with the advent of $crate and changes
in the compiler to expand macros to ::core::$foo in the context of a
#![no_std] crate.

The libcore inner module was also trimmed down a bit to the bare bones.

@alexcrichton
Copy link
Member Author

r? @brson

@rust-highfive rust-highfive assigned brson and unassigned nikomatsakis Jul 29, 2015
@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

This isn't actually necessary any more with the advent of `$crate` and changes
in the compiler to expand macros to `::core::$foo` in the context of a
`#![no_std]` crate.

The libcore inner module was also trimmed down a bit to the bare bones.
@alexcrichton alexcrichton force-pushed the remove-curious-inner branch 2 times, most recently from b90d903 to 5af6cf9 Compare July 29, 2015 21:19
@brson
Copy link
Contributor

brson commented Jul 29, 2015

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 29, 2015

📌 Commit 5af6cf9 has been approved by brson

@Gankra
Copy link
Contributor

Gankra commented Jul 30, 2015

RIP 😿

@bors
Copy link
Collaborator

bors commented Jul 30, 2015

⌛ Testing commit 5af6cf9 with merge 1038d08...

@bors
Copy link
Collaborator

bors commented Jul 30, 2015

💔 Test failed - auto-mac-32-opt

@alexcrichton
Copy link
Member Author

@bors: retry

On Thu, Jul 30, 2015 at 9:18 AM, bors [email protected] wrote:

[image: 💔] Test failed - auto-mac-32-opt
http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/5951


Reply to this email directly or view it on GitHub
#27388 (comment).

@bors
Copy link
Collaborator

bors commented Jul 30, 2015

⌛ Testing commit 5af6cf9 with merge 6edc994...

bors added a commit that referenced this pull request Jul 30, 2015
This isn't actually necessary any more with the advent of `$crate` and changes
in the compiler to expand macros to `::core::$foo` in the context of a
`#![no_std]` crate.

The libcore inner module was also trimmed down a bit to the bare bones.
@bors bors merged commit 5af6cf9 into rust-lang:master Jul 30, 2015
@alexcrichton alexcrichton deleted the remove-curious-inner branch August 17, 2015 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants