Fail to configure without an LLVM-friendly Python #2722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses issue rust-lang#2720. According to LLVM's documentation, it requires a version of Python between 2.4 and 2.7. Without the proper version, LLVM fails to build with cryptic errors. Prior to this commit, the configure script checked for the `python` command in the environment, but didn't actually check the version, which can cause problems e.g. on Linux distros where the default is Python 3. Now the configure script always prefers to select a more specific version of Python when available, in the order `python2.7` > `python2.6` > `python2` > `python`, and will always check to ensure that the interpreter's version is in the correct range.
brson
added a commit
that referenced
this pull request
Jun 26, 2012
Fail to configure without an LLVM-friendly Python
|
Thanks! |
celinval
pushed a commit
to celinval/rust-dev
that referenced
this pull request
Jun 4, 2024
1. Build and run regression tests, and create a labelled PR (Z-BenchCI) when these pass. 2. File an issue instead of creating a PR when either of the checks fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #2720. According to LLVM's documentation, it requires a
version of Python between 2.4 and 2.7. Without the proper version, LLVM fails
to build with cryptic errors. Prior to this commit, the configure script
checked for the
pythoncommand in the environment, but didn't actually checkthe version, which can cause problems e.g. on Linux distros where the default
is Python 3. Now the configure script always prefers to select a more specific
version of Python when available, in the order
python2.7>python2.6>python2>python, and will always check to ensure that the interpreter'sversion is in the correct range.