Skip diagnostic codes occurring inside a long diagnostic in errorck. #26984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
@brson Comments have been added |
|
@bors r+ Thanks! |
|
📌 Commit 4630fc7 has been approved by |
bors
added a commit
that referenced
this pull request
Jul 13, 2015
Currently errorck yields bogus `duplicate error code` messages when an error code occurs inside of a long diagnostic message (see #26982), because errorck just goes line by line checking for error codes and recording them all. A simplistic approach to fixing this is just to detect the beginning of a long diagnostic raw string literal (`r##"`) and skip lines until the end of the raw string literal is encountered. I'm not completely confident in this approach, but I think a more robust approach would be more complicated and I wanted to get feedback before pursuing that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently errorck yields bogus
duplicate error codemessages when an error code occurs inside of a long diagnostic message (see #26982), because errorck just goes line by line checking for error codes and recording them all.A simplistic approach to fixing this is just to detect the beginning of a long diagnostic raw string literal (
r##") and skip lines until the end of the raw string literal is encountered. I'm not completely confident in this approach, but I think a more robust approach would be more complicated and I wanted to get feedback before pursuing that.