Fix ICE caused by Drop implementations for unsized types #26759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
| struct Wrapper<T: ?Sized>(T); | ||
|
|
||
| impl<T: ?Sized> Drop for Wrapper<T> { | ||
| fn drop(&mut self) {} |
There was a problem hiding this comment.
Check that the destructor is really called correctly.
There was a problem hiding this comment.
I went for a check that uses a pointer stored in the struct, to make sure that drop() is called with the right arguments.
|
r=me once the test is expanded as described above. |
|
@bors r=pnkfelix |
|
📌 Commit eaeede2 has been approved by |
bors
added a commit
that referenced
this pull request
Jul 3, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26709