Skip to content

Mention that enum constructors are functions #26142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2015

Conversation

steveklabnik
Copy link
Member

Fixes #25850

@rust-highfive
Copy link
Contributor

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

@steveklabnik
Copy link
Member Author

r? @alexcrichton

@Gankra
Copy link
Contributor

Gankra commented Jun 9, 2015

Strings seem distracting in this example. &'static str or i32 might keep this simpler unless there's a reason to avoid them?

@steveklabnik
Copy link
Member Author

I kept Strings because they're used in the enum above, specifically to avoid dealing with lifetime and copy issues.

@Gankra
Copy link
Contributor

Gankra commented Jun 9, 2015

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 9, 2015

📌 Commit b242a86 has been approved by Gankro

Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 10, 2015
bors added a commit that referenced this pull request Jun 10, 2015
@bors bors merged commit b242a86 into rust-lang:master Jun 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants