Remove old_io from trpl/concurrency.md #24024
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
|
This potentially fixes #24023 Still building beta -- will double check once that's done. |
|
Oh, silly me. Duration is unused now. So those can be pulled, too. Let me update the PR real quick. |
This block is supposed to be a mirror of the block above it, but with most lines commented out to focus on the inner function body. However, a few lines were missing in the commented region.
|
Duplicated effort sadly: #23871 |
|
Doh, sorry @tshepang :) As of this last commit (adf8e11), all of the code samples compile and run (or fail) as expected in 1.0.0-beta. r? @steveklabnik :) |
| @@ -272,6 +258,8 @@ thread::spawn(move || { | |||
| data[i] += 1; | |||
| }); | |||
| # } | |||
| # | |||
| # thread::sleep_ms(50); | |||
There was a problem hiding this comment.
That block is supposed to be a mirror of the block above it, but with most lines commented out to focus on the inner function body.
For whatever reason, it didn't include the sleep, even in the current version of the document (https://github.com/rust-lang/rust/blob/80def6c2447d23a624e611417f24cf0ab2a5a676/src/doc/trpl/concurrency.md)
This is effectively a no-op, since the commented parts get elided when rendered (see http://doc.rust-lang.org/book/concurrency.html), but it was clearly intended to be a mirror of the previous block at some point. This brings it back into line with that.
|
Will you squash these commits please, except maybe callahad@adf8e11. |
|
Yes, thanks so much! r=me after a squash |
|
Closing in favor of squished PR |
…veklabnik Also: the std_misc feature flag is removed; it's not needed in Beta. Hat tip to @tshepang in rust-lang#23871 Fixes rust-lang#24023 This PR replaces rust-lang#24024
No description provided.