Emit proper attributes for the self pointer in method call through trait... #22935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @eddyb |
| }, | ||
| _ => method_ty | ||
| }; | ||
| let method_ty = common::monomorphize_type(bcx, method_ty); |
There was a problem hiding this comment.
Does bcx not have a method for this? common is rather jarring IMO (though I dislike the module more than the name).
…ait objects For method calls through trait objects, we currently generate the llvm function argument attributes using the non-opaque method signature that still has the trait object fat pointer for the self pointer. This leads to attributes that are plain wrong, e.g. noalias. As we don't know anything about the concrete type of the underlying object, we must replace the self argument with an opaque i8 pointer before applying the attributes.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 1, 2015
... objects For method calls through trait objects, we currently generate the llvm function argument attributes using the non-opaque method signature that still has the trait object fat pointer for the self pointer. This leads to attributes that are plain wrong, e.g. noalias. As we don't know anything about the concrete type of the underlying object, we must replace the self argument with an opaque i8 pointer before applying the attributes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... objects
For method calls through trait objects, we currently generate the llvm
function argument attributes using the non-opaque method signature that
still has the trait object fat pointer for the self pointer. This leads
to attributes that are plain wrong, e.g. noalias. As we don't know
anything about the concrete type of the underlying object, we must
replace the self argument with an opaque i8 pointer before applying the
attributes.