Skip to content

Move hash module from collections to core #19800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2014
Merged

Conversation

sfackler
Copy link
Member

@alexcrichton
Copy link
Member

Looks like there are some tidy errors with coretest, and can you also make sure these files are included in coretest as well? I didn't see the mod hash or mod sip directives in the diff for that.

Other than that though, r=me, thanks!

@alexcrichton
Copy link
Member

Ah also, you may be able to change the hash implementations for some the core types like Option/Result to use deriving

@sfackler sfackler force-pushed the core-hash branch 2 times, most recently from fec7e2f to 2c4effd Compare December 14, 2014 02:18
bors added a commit that referenced this pull request Dec 14, 2014
Move hash module from collections to core

Reviewed-by: alexcrichton
@bors bors merged commit 24a8ef6 into rust-lang:master Dec 17, 2014
@sfackler sfackler deleted the core-hash branch December 18, 2014 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants