Fix Iterator::fuse example #17557
Merged
Fix Iterator::fuse example #17557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The for loop would *always* exaust the iterator previously, which seems like behavior that was not intended. It's still kind of a weird function.
|
You're changing the behavior of the function. Instead of summing all ints <= 5, it now sums until the first x > 5. It's just an example so it doesn't matter though.. |
|
@bluss the point is that the old version had no reason to use |
|
Oh, I'm a bit slow. I understand now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The for loop would always exaust the iterator previously, which seems
like behavior that was not intended. It's still kind of a weird
function.