rustdoc: Render where clauses as appropriate #17531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1630,11 +1631,12 @@ fn item_trait(w: &mut fmt::Formatter, cx: &Context, it: &clean::Item, | |||
| } | |||
|
|
|||
| // Output the trait definition | |||
| try!(write!(w, "<pre class='rust trait'>{}trait {}{}{} ", | |||
| try!(write!(w, "<pre class='rust trait'>{}trait {}{}{} {} ", | |||
There was a problem hiding this comment.
Can you confirm that we don't see extra spaces if there are no where clauses for this and the cases below/above?
There was a problem hiding this comment.
It was indeed producing extra spaces.
tomjakubowski
force-pushed
the
rustdoc-where-clauses
branch
from
8fa5413 to
54831f1
Compare
|
Pushed with a fix for the spacing issue. |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Sep 29, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #16546