Fix ICE from null character #17472
Merged
Fix ICE from null character #17472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port_name value strings.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon. |
|
|
| @@ -2670,6 +2670,15 @@ fn exported_name(ccx: &CrateContext, id: ast::NodeId, | |||
| } | |||
| } | |||
|
|
|||
| fn contains_null(s: &str) -> bool { | |||
There was a problem hiding this comment.
Could this just be replaced with .bytes().contains(0)?
There was a problem hiding this comment.
It doesn't look like the iterator implements any contains method. I did change it to use any() though.
There was a problem hiding this comment.
@kaseyc It doesn't look like you pushed this revision to the PR. Once you do, I think it's ready to go!
There was a problem hiding this comment.
Yeah, I'm waiting for the change to finish a pass through make check, just to be thorough.
bors
added a commit
that referenced
this pull request
Sep 24, 2014
Add checks for null bytes in the value strings for the export_name and link_section attributes, reporting an error if any are found, before calling with_c_str on them. Fixes #16478
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Jul 28, 2024
rust-lang#17470 - run unit tests at the crate level not workspace For rust-lang/rust-analyzer#17470 Use the test path to identify a package in the workspace and run the unit test there instead of at the workspace.
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Aug 1, 2024
rust-lang#17470 - run unit tests at the crate level not workspace For rust-lang/rust-analyzer#17470 Use the test path to identify a package in the workspace and run the unit test there instead of at the workspace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add checks for null bytes in the value strings for the export_name and link_section attributes, reporting an error if any are found, before calling with_c_str on them.
Fixes #16478