Fix some ICEs and annoyances surrounding ! type
#17408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents error spam when attempting to look up overload traits.
Later compiler passes are not prepared to deal with deref of `ty_bot` and will generate various ICEs, so disallow it outright for now. Closes issue rust-lang#17373
This avoids ICEs in later passes that cannot cope with this construct
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. |
|
Thanks for looking into this! You can see some related work in the past here as well: #14574. I believe the conclusion there was that these operations would generate new inference variables instead of the bottom type (see more here as well #14973). That being said I do like having ICEs fixed for now. @nikomatsakis do you have an opinion on waiting for #14973 being dealt with first or whether this should land in the meantime for dealing with the ICE? |
|
Yeah, this is intended to be an interim fix until the final fate of bot is sorted out. |
bors
added a commit
that referenced
this pull request
Sep 22, 2014
- Don't attempt to autoderef `!`. The `Deref`/`DerefMut` trait lookup would generate a bunch of unhelpful error spew. - Don't allow explicit deref of `!`, since later passes just ICE. This closes issue #17373 - Don't allow explicit index of `!`, since later passes just ICE. There does not seem to be an issue associated with this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!. TheDeref/DerefMuttrait lookup would generate a bunch of unhelpful error spew.!, since later passes just ICE. This closes issue ICE: Explicit deref of non-derefable type: ! #17373!, since later passes just ICE. There does not seem to be an issue associated with this