Skip to content

ignore uninitialized submodules when checking if ./configure should be re-run #17129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2014
Merged

ignore uninitialized submodules when checking if ./configure should be re-run #17129

merged 1 commit into from
Sep 10, 2014

Conversation

spernsteiner
Copy link
Contributor

Currently ./configure --llvm-root=... and similar flags will break incremental builds by forcing reconfiguration on every make. This happens because reconfig.mk incorrectly treats submodules in the - (uninitialized) state as requiring reconfiguration, and ./configure deliberately deinitializes unneeded submodules. The fix is to reconfigure only when submodules are in the + state (wrong commit checked out).

bors added a commit that referenced this pull request Sep 10, 2014
Currently `./configure --llvm-root=...` and similar flags will break incremental builds by forcing reconfiguration on every `make`.  This happens because `reconfig.mk` incorrectly treats submodules in the `-` (uninitialized) state as requiring reconfiguration, and `./configure` deliberately deinitializes unneeded submodules.  The fix is to reconfigure only when submodules are in the `+` state (wrong commit checked out).
@bors bors closed this Sep 10, 2014
@bors bors merged commit ba43f7b into rust-lang:master Sep 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants