ignore uninitialized submodules when checking if ./configure should be re-run #17129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
./configure --llvm-root=...
and similar flags will break incremental builds by forcing reconfiguration on everymake
. This happens becausereconfig.mk
incorrectly treats submodules in the-
(uninitialized) state as requiring reconfiguration, and./configure
deliberately deinitializes unneeded submodules. The fix is to reconfigure only when submodules are in the+
state (wrong commit checked out).