Skip to content

Fixing a mismatched square bracket typo in src/libstd/slice.rs #14533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libstd/slice.rs
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ These traits include `ImmutableVector`, and `MutableVector` for the `&mut [T]`
case.

An example is the method `.slice(a, b)` that returns an immutable "view" into
a vector or a vector slice from the index interval `[a, b)`:
a vector or a vector slice from the index interval `[a, b]`:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a typo. Conventionally, the notation [ means "inclusive" and the ) means "exclusive". I.e. [a,b] is {a, a+1, ..., b-1, b} while [a,b) is just {a, a+1, ..., b-1}.

The latter is exactly the behaviour that .slice has.

(I'm going to close, but thanks for reading our docs closely and taking the time to submit a patch! ❤️ )

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know! Thanks!


```rust
let numbers = [0, 1, 2];
Expand Down