Skip to content

Update cargo #141796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2025
Merged

Update cargo #141796

merged 1 commit into from
May 31, 2025

Conversation

weihanglo
Copy link
Member

12 commits in 68db37499f2de8acef704c73d9031be6fbcbaee4..64a12460708cf146e16cc61f28aba5dc2463bbb4
2025-05-22 14:27:15 +0000 to 2025-05-30 18:25:08 +0000

r? ghost

@rustbot
Copy link
Collaborator

rustbot commented May 30, 2025

Some changes occurred in src/tools/cargo

cc @ehuss

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 30, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 30, 2025

⚠️ Warning ⚠️

  • Some commits in this PR modify submodules.

@weihanglo
Copy link
Member Author

@bors r+ rollup=never p=1

@bors
Copy link
Collaborator

bors commented May 30, 2025

📌 Commit 01541e1 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 30, 2025
@bors
Copy link
Collaborator

bors commented May 31, 2025

⌛ Testing commit 01541e1 with merge 7a7bcbb...

@bors
Copy link
Collaborator

bors commented May 31, 2025

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 7a7bcbb to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 31, 2025
@bors bors merged commit 7a7bcbb into rust-lang:master May 31, 2025
10 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 31, 2025
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 0b00e68 (parent) -> 7a7bcbb (this PR)

Test differences

Show 33445 test diffs

Stage 1

  • errors::verify_ast_passes_out_of_order_params_36: pass -> [missing] (J0)
  • errors::verify_builtin_macros_env_not_defined_52: pass -> [missing] (J0)
  • errors::verify_parse_macro_invocation_with_qualified_path_9: pass -> [missing] (J0)
  • errors::verify_passes_repr_conflicting_75: pass -> [missing] (J0)
  • interval::tests::insert_range_dual: pass -> [missing] (J0)
  • parser::tests::multiple_labels_without_message_2: pass -> [missing] (J0)
  • session_diagnostics::verify_attr_parsing_repr_ident_31: pass -> [missing] (J0)
  • spec::tests::arm64e_apple_ios: pass -> [missing] (J0)
  • transitive_relation::tests::test_one_step: pass -> [missing] (J0)
  • sort::tests::unstable::deterministic_string_saw_mixed: ignore -> [missing] (J1)
  • sort::tests::unstable::panic_retain_orig_set_string_saw_mixed: ignore -> [missing] (J1)
  • collections::binary_heap::test_drain_sorted_collect: pass -> [missing] (J2)
  • collections::btree::map::tests::test_extract_if::underfull_keeping_one: pass -> [missing] (J2)
  • collections::linked_list::tests::test_mut_iter: pass -> [missing] (J2)
  • errors_that_start_with_newline_formats_correctly: pass -> [missing] (J2)
  • floats::f128::test_is_sign_positive: pass -> [missing] (J2)
  • fmt::builders::debug_map::test_empty: pass -> [missing] (J2)
  • lazy::lazy_type_inference: pass -> [missing] (J2)
  • lazy_lock::sync_lazy_new: pass -> [missing] (J2)
  • mpmc::oneshot_single_thread_send_port_close: pass -> [missing] (J2)
  • mutex::smoke: pass -> [missing] (J2)
  • net::ip_addr::test_from_str_ipv4_in_ipv6: pass -> [missing] (J2)
  • num::i32::test_carrying_mul_add: pass -> [missing] (J2)
  • num::i8::test_unbounded_shl: pass -> [missing] (J2)
  • num::test_try_i32u32: pass -> [missing] (J2)
  • num::test_try_i8u32: pass -> [missing] (J2)
  • once_lock::sync_once_cell_does_not_leak_partially_constructed_boxes: pass -> [missing] (J2)
  • slice::test_chunks_exact_zip: pass -> [missing] (J2)
  • sort::tests::unstable::correct_1k_random_z1: pass -> [missing] (J2)
  • str::ceil_char_boundary: pass -> [missing] (J2)
  • sync::test_arc_cyclic_with_zero_refs: pass -> [missing] (J2)
  • sync::test_cowarc_clone_make_mut: pass -> [missing] (J2)
  • test_var_big: pass -> [missing] (J2)
  • ascii::medium::is_ascii_alphanumeric: pass -> [missing] (J3)
  • iter::bench_max: pass -> [missing] (J3)
  • net::tcp::tests::multiple_connect_interleaved_lazy_schedule: pass -> [missing] (J3)
  • path::bench_path_hashset_miss: pass -> [missing] (J3)
  • sort::tests::stable::stability_i32_ascending: pass -> [missing] (J3)
  • sort::tests::unstable::stability_i32_random_d2: pass -> [missing] (J3)
  • str::chars_count::short_mixed: pass -> [missing] (J3)
  • tests::parse_ignored_flag: pass -> [missing] (J3)

Stage 2

  • errors::verify_ast_passes_optional_trait_object_48: [missing] -> pass (J0)
  • errors::verify_ast_passes_unsafe_negative_impl_38: [missing] -> pass (J0)
  • errors::verify_expand_duplicate_matcher_binding_35: [missing] -> pass (J0)
  • errors::verify_incremental_unchecked_clean_17: [missing] -> pass (J0)
  • errors::verify_parse_asm_expected_comma_179: [missing] -> pass (J0)
  • errors::verify_parse_enum_pattern_instead_of_identifier_123: [missing] -> pass (J0)
  • errors::verify_parse_macro_rules_missing_bang_152: [missing] -> pass (J0)
  • errors::verify_passes_implied_feature_not_exist_160: [missing] -> pass (J0)
  • html::render::tests::test_all_types_prints_header_once: [missing] -> pass (J0)
  • html::render::write_shared::tests::hack_external_crate_names: [missing] -> pass (J0)
  • html::toc::tests::builder_smoke: [missing] -> pass (J0)
  • spec::tests::riscv32imac_unknown_none_elf: [missing] -> pass (J0)
  • sort::tests::stable::correct_u128_random_d20: [missing] -> ignore (J1)
  • sort::tests::stable::self_cmp_string_random_s95: [missing] -> ignore (J1)
  • sort::tests::stable::stability_legacy: [missing] -> ignore (J1)
  • sort::tests::unstable::correct_dyn_val_random_d2: [missing] -> ignore (J1)
  • sort::tests::unstable::panic_retain_orig_set_string_random_s95: [missing] -> ignore (J1)
  • atomic::int_xor: [missing] -> pass (J2)
  • collections::btree::map::tests::test_into_iter_drop_leak_kv_panic_in_val: [missing] -> pass (J2)
  • collections::btree::map::tests::test_iter_rev: [missing] -> pass (J2)
  • ffi::os_str::tests::test_os_string_reserve: [missing] -> pass (J2)
  • fmt::builders::debug_list::test_empty_non_exhaustive: [missing] -> pass (J2)
  • fmt::num::test_format_int_flags: [missing] -> pass (J2)
  • io::borrowed_buf::new: [missing] -> pass (J2)
  • io::cursor::tests::test_buf_writer_error: [missing] -> pass (J2)
  • io::tests::read_to_end_error: [missing] -> pass (J2)
  • iter::sources::test_repeat_take: [missing] -> pass (J2)
  • iter::traits::accum::test_iterator_sum_result: [missing] -> pass (J2)
  • iter::traits::iterator::test_iterator_min: [missing] -> pass (J2)
  • num::dec2flt::massive_exponent: [missing] -> pass (J2)
  • num::flt2dec::strategy::dragon::shortest_sanity_test: [missing] -> pass (J2)
  • num::i64::test_be: [missing] -> pass (J2)
  • num::ops::test_add_defined: [missing] -> pass (J2)
  • num::ops::test_shl_defined: [missing] -> pass (J2)
  • num::ops::test_sub_assign_defined: [missing] -> pass (J2)
  • num::u128::test_widening_mul: [missing] -> pass (J2)
  • slice::test_chunks_exact_count: [missing] -> pass (J2)
  • sort::tests::unstable::panic_retain_orig_set_cell_i32_random_z1: [missing] -> pass (J2)
  • str::test_find_str: [missing] -> pass (J2)
  • str::test_trim: [missing] -> pass (J2)
  • string::test_from_utf8_lossy: [missing] -> pass (J2)
  • sync::test_strong_count: [missing] -> pass (J2)
  • vec::test_drain_keep_rest: [missing] -> pass (J2)
  • vec_deque::test_try_fold_wraparound: [missing] -> pass (J2)
  • ascii::medium::is_ascii_punctuation: [missing] -> pass (J3)
  • btree::set::is_subset_10k_vs_100: [missing] -> pass (J3)
  • fmt::write_vec_macro_debug: [missing] -> pass (J3)
  • iter::bench_range_step_by_loop_u32: [missing] -> pass (J3)
  • net::addr_parser::bench_parse_socketaddr_v4: [missing] -> pass (J3)
  • net::tcp::tests::multiple_connect_serial: [missing] -> pass (J3)
  • num::dec2flt::bench_short_decimal: [missing] -> pass (J3)
  • num::flt2dec::strategy::dragon::bench_big_exact_3: [missing] -> pass (J3)
  • sort::tests::stable::correct_1k_saw_mixed: [missing] -> pass (J3)
  • sort::tests::stable::correct_cell_i32_random: [missing] -> pass (J3)
  • sort::tests::stable::self_cmp_i32_random: [missing] -> pass (J3)
  • sort::tests::unstable::correct_string_saw_mixed: [missing] -> pass (J3)
  • str::splitn_space_char::long_lorem_ipsum: [missing] -> pass (J3)
  • sys::pal::common::tests::bench_heap_path_alloc: [missing] -> pass (J3)
  • vec::bench_clone_0000: [missing] -> pass (J3)

(and 16633 additional test diffs)

Additionally, 16712 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 7a7bcbbcdbf2845164a94377d0e0efebb737ffd3 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-apple-2: 6941.9s -> 1171.8s (-83.1%)
  2. dist-aarch64-linux: 5338.9s -> 8041.2s (50.6%)
  3. test-various: 4217.6s -> 2233.1s (-47.1%)
  4. x86_64-gnu-aux: 5574.2s -> 3723.5s (-33.2%)
  5. dist-apple-various: 8959.0s -> 7080.9s (-21.0%)
  6. dist-aarch64-apple: 5626.3s -> 4675.9s (-16.9%)
  7. x86_64-gnu-llvm-20-2: 6128.9s -> 7152.8s (16.7%)
  8. aarch64-apple: 5365.8s -> 5888.1s (9.7%)
  9. x86_64-apple-1: 8147.8s -> 7365.8s (-9.6%)
  10. x86_64-msvc-2: 7451.8s -> 6825.4s (-8.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (7a7bcbb): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
0.3% [0.2%, 0.4%] 2
Regressions ❌
(secondary)
0.4% [0.4%, 0.4%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.3% [0.2%, 0.4%] 2

Max RSS (memory usage)

Results (primary 2.3%, secondary 0.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
6.2% [3.0%, 9.4%] 3
Regressions ❌
(secondary)
0.8% [0.4%, 1.7%] 9
Improvements ✅
(primary)
-9.4% [-9.4%, -9.4%] 1
Improvements ✅
(secondary)
-0.8% [-1.6%, -0.5%] 4
All ❌✅ (primary) 2.3% [-9.4%, 9.4%] 4

Cycles

Results (secondary 0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.5% [0.5%, 3.8%] 7
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.8% [-1.4%, -0.4%] 11
All ❌✅ (primary) - - 0

Binary size

Results (primary -0.0%, secondary -0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.1% [0.0%, 0.1%] 5
Regressions ❌
(secondary)
0.0% [0.0%, 0.1%] 2
Improvements ✅
(primary)
-0.1% [-0.2%, -0.1%] 7
Improvements ✅
(secondary)
-0.2% [-0.2%, -0.2%] 1
All ❌✅ (primary) -0.0% [-0.2%, 0.1%] 12

Bootstrap: 777.559s -> 778.793s (0.16%)
Artifact size: 370.18 MiB -> 370.46 MiB (0.08%)

@weihanglo weihanglo deleted the update-cargo branch May 31, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants