-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Fix glob import tests #141060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix glob import tests #141060
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Suggestion:
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
#![allow(unused_imports, dead_code)] | ||
|
||
mod test1 { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Suggestion: can you rename these test modules as something more semantically meaningful, e.g.
|
||
mod foo { | ||
pub struct P; | ||
} | ||
|
||
mod bar { | ||
pub struct P; | ||
} | ||
|
||
pub mod baz { | ||
use test1::foo::*; | ||
use test1::bar::*; | ||
|
||
pub fn f() { | ||
let _ = P; //~ ERROR `P` is ambiguous | ||
} | ||
} | ||
} | ||
|
||
mod test2 { | ||
mod foo { | ||
pub struct P; | ||
} | ||
|
||
mod bar { | ||
pub struct P; | ||
} | ||
|
||
pub mod baz { | ||
use test2::foo::P; | ||
use test2::bar::P; //~ ERROR the name `P` is defined multiple times | ||
} | ||
} | ||
|
||
fn main() { | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
error[E0252]: the name `P` is defined multiple times | ||
--> $DIR/issue-7663.rs:33:13 | ||
| | ||
LL | use test2::foo::P; | ||
| ------------- previous import of the type `P` here | ||
LL | use test2::bar::P; | ||
| ^^^^^^^^^^^^^ `P` reimported here | ||
| | ||
= note: `P` must be defined only once in the type namespace of this module | ||
help: you can use `as` to change the binding name of the import | ||
| | ||
LL | use test2::bar::P as OtherP; | ||
| +++++++++ | ||
|
||
error[E0659]: `P` is ambiguous | ||
--> $DIR/issue-7663.rs:17:21 | ||
| | ||
LL | let _ = P; | ||
| ^ ambiguous name | ||
| | ||
= note: ambiguous because of multiple glob imports of a name in the same module | ||
note: `P` could refer to the unit struct imported here | ||
--> $DIR/issue-7663.rs:13:13 | ||
| | ||
LL | use test1::foo::*; | ||
| ^^^^^^^^^^^^^ | ||
= help: consider adding an explicit import of `P` to disambiguate | ||
note: `P` could also refer to the unit struct imported here | ||
--> $DIR/issue-7663.rs:14:13 | ||
| | ||
LL | use test1::bar::*; | ||
| ^^^^^^^^^^^^^ | ||
= help: consider adding an explicit import of `P` to disambiguate | ||
|
||
error: aborting due to 2 previous errors | ||
|
||
Some errors have detailed explanations: E0252, E0659. | ||
For more information about an error, try `rustc --explain E0252`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: a few things:
tests/ui/resolve/
, andnon-glob-vs-glob-reexport-precedence
//! Regression test for #14082
.