-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Hide unstable print kinds within emit_unknown_print_request_help in stable channel #139850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
tests/run-make/print-request-help-stable-unstable/help-diff.diff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
@@ -1,5 +1,5 @@ | ||
error: unknown print request: `xxx` | ||
| | ||
- = help: valid print requests are: `calling-conventions`, `cfg`, `code-models`, `crate-name`, `deployment-target`, `file-names`, `host-tuple`, `link-args`, `native-static-libs`, `relocation-models`, `split-debuginfo`, `stack-protector-strategies`, `sysroot`, `target-cpus`, `target-features`, `target-libdir`, `target-list`, `tls-models` | ||
+ = help: valid print requests are: `all-target-specs-json`, `calling-conventions`, `cfg`, `check-cfg`, `code-models`, `crate-name`, `crate-root-lint-levels`, `deployment-target`, `file-names`, `host-tuple`, `link-args`, `native-static-libs`, `relocation-models`, `split-debuginfo`, `stack-protector-strategies`, `supported-crate-types`, `sysroot`, `target-cpus`, `target-features`, `target-libdir`, `target-list`, `target-spec-json`, `tls-models` | ||
= help: for more information, see the rustc book: https://doc.rust-lang.org/rustc/command-line-arguments.html#--print-print-compiler-information | ||
|
33 changes: 33 additions & 0 deletions
33
tests/run-make/print-request-help-stable-unstable/rmake.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
//! Check that unstable print requests are omitted from help if compiler is in stable channel. | ||
//! | ||
//! Issue: <https://github.com/rust-lang/rust/issues/138698> | ||
use run_make_support::{diff, rustc, similar}; | ||
|
||
fn main() { | ||
let stable_invalid_print_request_help = rustc() | ||
.env("RUSTC_BOOTSTRAP", "-1") | ||
.cfg("force_stable") | ||
.print("xxx") | ||
.run_fail() | ||
.stderr_utf8(); | ||
assert!(!stable_invalid_print_request_help.contains("all-target-specs-json")); | ||
diff() | ||
.expected_file("stable-invalid-print-request-help.err") | ||
.actual_text("stable_invalid_print_request_help", &stable_invalid_print_request_help) | ||
.run(); | ||
|
||
let unstable_invalid_print_request_help = rustc().print("xxx").run_fail().stderr_utf8(); | ||
assert!(unstable_invalid_print_request_help.contains("all-target-specs-json")); | ||
diff() | ||
.expected_file("unstable-invalid-print-request-help.err") | ||
.actual_text("unstable_invalid_print_request_help", &unstable_invalid_print_request_help) | ||
.run(); | ||
|
||
let help_diff = similar::TextDiff::from_lines( | ||
&stable_invalid_print_request_help, | ||
&unstable_invalid_print_request_help, | ||
) | ||
.unified_diff() | ||
.to_string(); | ||
diff().expected_file("help-diff.diff").actual_text("help_diff", help_diff).run(); | ||
} |
5 changes: 5 additions & 0 deletions
5
tests/run-make/print-request-help-stable-unstable/stable-invalid-print-request-help.err
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
error: unknown print request: `xxx` | ||
| | ||
= help: valid print requests are: `calling-conventions`, `cfg`, `code-models`, `crate-name`, `deployment-target`, `file-names`, `host-tuple`, `link-args`, `native-static-libs`, `relocation-models`, `split-debuginfo`, `stack-protector-strategies`, `sysroot`, `target-cpus`, `target-features`, `target-libdir`, `target-list`, `tls-models` | ||
= help: for more information, see the rustc book: https://doc.rust-lang.org/rustc/command-line-arguments.html#--print-print-compiler-information | ||
|
5 changes: 5 additions & 0 deletions
5
tests/run-make/print-request-help-stable-unstable/unstable-invalid-print-request-help.err
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
error: unknown print request: `xxx` | ||
| | ||
= help: valid print requests are: `all-target-specs-json`, `calling-conventions`, `cfg`, `check-cfg`, `code-models`, `crate-name`, `crate-root-lint-levels`, `deployment-target`, `file-names`, `host-tuple`, `link-args`, `native-static-libs`, `relocation-models`, `split-debuginfo`, `stack-protector-strategies`, `supported-crate-types`, `sysroot`, `target-cpus`, `target-features`, `target-libdir`, `target-list`, `target-spec-json`, `tls-models` | ||
= help: for more information, see the rustc book: https://doc.rust-lang.org/rustc/command-line-arguments.html#--print-print-compiler-information | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.