Skip to content

Remove Control enum in favor of ControlFlow #135135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove Control enum in favor of ControlFlow #135135

wants to merge 1 commit into from

Conversation

compiler-errors
Copy link
Member

This enum probably got added before we had ControlFlow, and now it's redundant.

@rustbot
Copy link
Collaborator

rustbot commented Jan 5, 2025

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 5, 2025
@lqd
Copy link
Member

lqd commented Jan 5, 2025 •
edited
Loading

I already did that in #134920, it’s been reviewed already and am just waiting for jack’s final verification

@compiler-errors
Copy link
Member Author

kk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fee1-dead fee1-dead

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@compiler-errors @rustbot @lqd @fee1-dead