Add travis jobs for tidy #12417
Add travis jobs for tidy #12417
Conversation
|
While I think that this would certainly help some PRs, it's pretty rare that a tidy failure is the PR that fails. I could imagine that something like this could be extended to executing more pre-check functionality like verifying the format of a commit message (or something like that). Regardless, we should proceed carefully when adding more infrastructure to what already exists. |
|
Another option is something that looks like alexcrichton@715fc85 which completes in around 30 minutes. That exercises the |
|
If it's ok, I'm going to close this in favor of #12437 |
|
@alexcrichton totally, I didn't expect this to be merged as is. I wanted this PR to grow with comments of what it should or shouldn't do. |
…-schievink minor: Update commit/PR style guide What matters for the changelog is having PR title/description from the user's perspective, while commits can be internal.
Move `iter_nth` to `style`, add machine applicable suggestion There's no `O(n)` involved with `.iter().nth()` on the linted types since the iterator implementations provide `nth` and/or `advance_by` that operate in `O(1)` For slice iterators the codegen is equivalent, `VecDeque`'s iterator seems to codegen differently but that doesn't seem significant enough to keep it as a perf lint changelog: [`iter_nth`] Move to `style` r? `@flip1995`
I'm creating this PR to extend the discussion that started here and as an example of what we could do to improve our pre-gating / pre-review process.
Here's the link to the job executed by this commit.
If we decided to extend this to other
litejobs, the configure and make process will need to be tweaked a bit - for example,--disable-optimize- to ensure that it runs faster and just does a pre-check on the PR.This definitely needs more discussion.