-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Add core::iter::adapters::PeekMap
and core::iter::Peekable::peek_map
#118474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @m-ou-se (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
59094b0
to
e804588
Compare
You may want to file an ACP for discussion. It's not strictly required but it'll make it easier to separate API from implementation discussion. |
I'll look into that! Thank you! @the8472 |
This comment has been minimized.
This comment has been minimized.
You can leave out the unsafe trait impls if they cause issues. They exist for perf optimizations and can be added later if necessary. |
This comment has been minimized.
This comment has been minimized.
b3408cb
to
92c7d39
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
btw, you can run syntax-checking locally with https://rustc-dev-guide.rust-lang.org/building/how-to-build-and-run.html |
Noted, thank you. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Have you made the ACP already? I don't see one linked. I'm gonna make this as waiting on you for the ACP to be accepted. Use |
@MiguelX413 any updates on creating the ACP? thanks |
☔ The latest upstream changes (presumably #125443) made this pull request unmergeable. Please resolve the merge conflicts. |
Closing this as no ACP was created or linked to the pr |
Add a feature called peak_map.
I need to add further documentation but do need guidance as it's my first time contributing to Rust.