Skip to content

Add core::iter::adapters::PeekMap and core::iter::Peekable::peek_map #118474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

MiguelX413
Copy link

Add a feature called peak_map.
I need to add further documentation but do need guidance as it's my first time contributing to Rust.

@rustbot
Copy link
Collaborator

rustbot commented Nov 30, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @m-ou-se (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 30, 2023
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@MiguelX413 MiguelX413 force-pushed the master branch 2 times, most recently from 59094b0 to e804588 Compare November 30, 2023 18:49
@the8472
Copy link
Member

the8472 commented Nov 30, 2023

You may want to file an ACP for discussion. It's not strictly required but it'll make it easier to separate API from implementation discussion.

@MiguelX413
Copy link
Author

You may want to file an ACP for discussion. It's not strictly required but it'll make it easier to separate API from implementation discussion.

I'll look into that! Thank you! @the8472

@rust-log-analyzer

This comment has been minimized.

@the8472
Copy link
Member

the8472 commented Nov 30, 2023

You can leave out the unsafe trait impls if they cause issues. They exist for perf optimizations and can be added later if necessary.

@rust-log-analyzer

This comment has been minimized.

@MiguelX413 MiguelX413 force-pushed the master branch 2 times, most recently from b3408cb to 92c7d39 Compare November 30, 2023 19:06
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@the8472
Copy link
Member

the8472 commented Nov 30, 2023

btw, you can run syntax-checking locally with ./x check core --stage 0

https://rustc-dev-guide.rust-lang.org/building/how-to-build-and-run.html

@MiguelX413
Copy link
Author

btw, you can run syntax-checking locally with ./x check core --stage 0

https://rustc-dev-guide.rust-lang.org/building/how-to-build-and-run.html

Noted, thank you.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@Noratrieb
Copy link
Member

Have you made the ACP already? I don't see one linked. I'm gonna make this as waiting on you for the ACP to be accepted. Use @rustbot ready when it has been accepted.
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 22, 2024
@Dylan-DPC Dylan-DPC added the needs-acp This change is blocked on the author creating an ACP. label Feb 18, 2024
@Dylan-DPC
Copy link
Member

@MiguelX413 any updates on creating the ACP? thanks

@bors
Copy link
Collaborator

bors commented Jul 29, 2024

☔ The latest upstream changes (presumably #125443) made this pull request unmergeable. Please resolve the merge conflicts.

@Dylan-DPC
Copy link
Member

Closing this as no ACP was created or linked to the pr

@Dylan-DPC Dylan-DPC closed this Aug 2, 2024
@Dylan-DPC Dylan-DPC removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-acp This change is blocked on the author creating an ACP. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants