Skip to content

Use FreezeLock for CStore #115711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2023
Merged

Use FreezeLock for CStore #115711

merged 1 commit into from
Sep 10, 2023

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Sep 9, 2023

This uses FreezeLock to protect the CStore. FreezeReadGuard and FreezeWriteGuard are changed to support a map operation.

r? @oli-obk

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 9, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Sep 9, 2023

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 9, 2023
@bors
Copy link
Collaborator

bors commented Sep 9, 2023

⌛ Trying commit 1d8fdc0 with merge 73e9d0d...

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 9, 2023
Use `FreezeLock` for `CStore`

This uses `FreezeLock` to protect the `CStore`. `FreezeReadGuard` and `FreezeWriteGuard` are changed to support a `map` operation.

r? `@oli-obk`
@bors
Copy link
Collaborator

bors commented Sep 9, 2023

☀️ Try build successful - checks-actions
Build commit: 73e9d0d (73e9d0dfe548ffe86e60eb613f202da7c7574438)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (73e9d0d): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.4% [-3.4%, -1.5%] 2
Improvements ✅
(secondary)
-3.0% [-3.9%, -2.0%] 2
All ❌✅ (primary) -2.4% [-3.4%, -1.5%] 2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.0% [-3.0%, -3.0%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 626.843s -> 629.492s (0.42%)
Artifact size: 317.92 MiB -> 317.99 MiB (0.02%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 10, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Sep 10, 2023

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 10, 2023

📌 Commit 1d8fdc0 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 10, 2023
@bors
Copy link
Collaborator

bors commented Sep 10, 2023

⌛ Testing commit 1d8fdc0 with merge 6645a93...

@bors
Copy link
Collaborator

bors commented Sep 10, 2023

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 6645a93 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 10, 2023
@bors bors merged commit 6645a93 into rust-lang:master Sep 10, 2023
@rustbot rustbot added this to the 1.74.0 milestone Sep 10, 2023
@Zoxc Zoxc deleted the freeze-cstore branch September 10, 2023 12:57
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6645a93): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 629.364s -> 630.365s (0.16%)
Artifact size: 317.94 MiB -> 318.00 MiB (0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants