Code

Update Clippy#114310

Code

Merged

bors merged 148 commits intorust-lang:masterrust-lang/rust:masterfrom

flip1995:clippyupflip1995/rust:clippyupCopy head branch name to clipboard

Aug 1, 2023

Commits

Commits on Jun 30, 2023

• lint on matches and pattern matching

  y21

  committed
  648d1ae

  Copy full SHA for 648d1ae

Commits on Jul 13, 2023

• New lint [`four_forward_slashes`]

  Show description for 885ce61
  Centri3

  committed
  885ce61

  Copy full SHA for 885ce61

• Improve suggestion and add more tests

  Centri3

  committed
  2e43d0c

  Copy full SHA for 2e43d0c

• Fix ICE on None.unwrap_or_default()

  syvb

  committed
  c2aaa62

  Copy full SHA for c2aaa62

• Add handling for None.unwrap_or(_else)

  syvb

  committed
  8d258c1

  Copy full SHA for 8d258c1

Commits on Jul 14, 2023

• refactor(rustc_middle): Substs -> GenericArg

  mdibaiee

  committed
  fdb2e36

  Copy full SHA for fdb2e36

• [significant_drop_tightening] Fix #11160

  c410-f3r

  committed
  1f82f6d

  Copy full SHA for 1f82f6d

Commits on Jul 16, 2023

• clippy-driver: Update bug URL to use the ice template

  xFrednet

  committed
  f928d78

  Copy full SHA for f928d78

• [`semicolon_if_nothing_returned`]: enable the autofix

  sylvestre

  committed
  eaccc6d

  Copy full SHA for eaccc6d

• [`semicolon_if_nothing_returned`]: Update the tests with the autofix

  sylvestre

  committed
  8ebdd62

  Copy full SHA for 8ebdd62

Commits on Jul 17, 2023

• Auto merge of #11168 - xFrednet:00000-free-ice-cream, r=flip1995

  Show description for 9109533
  bors

  committed
  9109533

  Copy full SHA for 9109533

• Auto merge of #11083 - sylvestre:autofix, r=dswij

  Show description for 568ccf3
  bors

  committed
  568ccf3

  Copy full SHA for 568ccf3

• Merge commit 'd9c24d1b1ee61f276e550b967409c9f155eac4e3' into clippyup

  flip1995

  committed
  d6d530f

  Copy full SHA for d6d530f

• Another fix for incorrect_impls

  flip1995

  committed
  2feb9a5

  Copy full SHA for 2feb9a5

• new lint: `format_collect`

  y21

  committed
  c388156

  Copy full SHA for c388156

• document that `write!`ing into a string never fails

  y21

  committed
  c83d58f

  Copy full SHA for c83d58f

• Rewrite [`tuple_array_conversions`]

  Centri3

  committed
  74a7704

  Copy full SHA for 74a7704

• Move tuple_array_conversions to nursery

  Alexendoo

  committed
  36f84a6

  Copy full SHA for 36f84a6

• Auto merge of #11172 - Alexendoo:tuple-array-conversions-nursery, r=xFrednet

  Show description for 54fa922
  bors

  committed
  54fa922

  Copy full SHA for 54fa922

• Don't lint `needless_return` in fns across a macro boundary

  Alexendoo

  committed
  d24f0d0

  Copy full SHA for d24f0d0

• Auto merge of #11116 - y21:format_collect, r=Manishearth

  Show description for 410456d
  bors

  committed
  410456d

  Copy full SHA for 410456d

• Auto merge of #11173 - Alexendoo:needless-return-fn-macro, r=Manishearth

  Show description for 3e0170b
  bors

  committed
  3e0170b

  Copy full SHA for 3e0170b

• [`redundant_pattern_matching`]: don't lint if if guards are present

  y21

  committed
  c26801e

  Copy full SHA for c26801e

• add guard to suggestion instead of not linting

  y21

  committed
  e7fd44f

  Copy full SHA for e7fd44f

• Rename arg_iter to iter_instantiated

  compiler-errors

  committed
  d1e1dcb

  Copy full SHA for d1e1dcb

Commits on Jul 18, 2023

• New lint `needless_return_with_try`

  Centri3

  committed
  c13cb54

  Copy full SHA for c13cb54

• Auto merge of #11171 - Centri3:tuple_array_conversions, r=llogiq

  Show description for 747df85
  bors

  committed
  747df85

  Copy full SHA for 747df85

• Rename to `needless_return_with_question_mark`

  Centri3

  committed
  0d59d1d

  Copy full SHA for 0d59d1d

• Auto merge of #11140 - Centri3:four_forward_slashes, r=blyxyas

  Show description for 9f0cbfd
  bors

  committed
  9f0cbfd

  Copy full SHA for 9f0cbfd

• New lint [`error_impl_error`]

  Centri3

  committed
  75e1329

  Copy full SHA for 75e1329

• Add `allow_private_error` config option

  Centri3

  committed
  f4b3bb1

  Copy full SHA for f4b3bb1

• Remove `#![allow(unused)]` and `--crate-name` from new_lint tests

  Alexendoo

  committed
  9c6b17e

  Copy full SHA for 9c6b17e

• Remove unused flags from ui-cargo tests

  Alexendoo

  committed
  f539e1a

  Copy full SHA for f539e1a

• Fix async functions handling for `needless_pass_by_ref_mut` lint

  GuillaumeGomez

  committed
  8b0540b

  Copy full SHA for 8b0540b

• Update `needless_pass_by_ref_mut` ui test

  GuillaumeGomez

  committed
  5e9e462

  Copy full SHA for 5e9e462

• Auto merge of #11175 - y21:issue11174, r=Manishearth

  Show description for d4a6634
  bors

  committed
  d4a6634

  Copy full SHA for d4a6634

Commits on Jul 19, 2023

• New lint [`string_lit_chars_any`]

  Centri3

  committed
  9d08502

  Copy full SHA for 9d08502

• Auto merge of #11052 - Centri3:string_lit_chars_any, r=Jarcho

  Show description for ec57155
  bors

  committed
  ec57155

  Copy full SHA for ec57155

• Remove the configuration option

  Show description for 19b0e84
  Centri3

  committed
  19b0e84

  Copy full SHA for 19b0e84

• new lint `iter_skip_zero`

  Centri3

  committed
  4c79d8a

  Copy full SHA for 4c79d8a

• Auto merge of #11046 - Centri3:iter_skip_zero, r=blyxyas

  Show description for 3dd6af9
  bors

  committed
  3dd6af9

  Copy full SHA for 3dd6af9

• check for fully qualified paths in `unnecessary_cast`

  Centri3

  committed
  dcfc6a2

  Copy full SHA for dcfc6a2

• Fix `unwrap_or_else_default` false positive

  smoelius

  committed
  f583fd1

  Copy full SHA for f583fd1

• Auto merge of #11183 - Alexendoo:new-lint-template, r=xFrednet

  Show description for 0fa1fd3
  bors

  committed
  0fa1fd3

  Copy full SHA for 0fa1fd3

• Auto merge of #11135 - smoelius:unwrap_or_else_default-fp, r=Centri3

  Show description for 7a34143
  bors

  committed
  7a34143

  Copy full SHA for 7a34143

• Auto merge of #10949 - y21:issue8010, r=Alexendoo

  Show description for 0b63e95
  bors

  committed
  0b63e95

  Copy full SHA for 0b63e95

• On nightly, dump ICE backtraces to disk

  Show description for cbca8f9
  estebank

  committed
  cbca8f9

  Copy full SHA for cbca8f9

Commits on Jul 20, 2023

• Merge `unwrap_or_else_default.rs` into `or_fun_call.rs`

  smoelius

  committed
  84c4112

  Copy full SHA for 84c4112

• Rename `unwrap_or_else_default` to `unwrap_or_default`

  smoelius

  committed
  e27977b

  Copy full SHA for e27977b

• Auto merge of #11107 - Centri3:error_impl_error, r=Jarcho

  Show description for d71fbb9
  bors

  committed
  d71fbb9

  Copy full SHA for d71fbb9

• Auto merge of #11161 - c410-f3r:let-chain, r=dswij

  Show description for d764a0e
  bors

  committed
  d764a0e

  Copy full SHA for d764a0e

• Add Centri3 and blyxyas to the reviewer rotation

  Show description for 579f1ec
  flip1995

  committed
  579f1ec

  Copy full SHA for 579f1ec

• Extract the logic for if a snippet equals a type

  Centri3

  committed
  15b68c2

  Copy full SHA for 15b68c2

• Auto merge of #11194 - flip1995:new-reviewers, r=xFrednet

  Show description for 0f31fff
  bors

  committed
  0f31fff

  Copy full SHA for 0f31fff

• Auto merge of #10971 - Centri3:unnecessary_cast_fully_qual_fix, r=dswij

  Show description for fbe292e
  bors

  committed
  fbe292e

  Copy full SHA for fbe292e

• XSimplifiedType to SimplifiedType::X

  lcnr

  committed
  5a6c4d7

  Copy full SHA for 5a6c4d7

• fix: false positive for `option_env!` in ifs

  Show description for f743fec
  thvdveld

  committed
  f743fec

  Copy full SHA for f743fec

• Auto merge of #11106 - syvb:literal_unwrap_ice, r=dswij

  Show description for fca1f9a
  bors

  committed
  fca1f9a

  Copy full SHA for fca1f9a

• [significant_drop_tightening] Fix #11189

  c410-f3r

  committed
  f0a16bb

  Copy full SHA for f0a16bb

• Auto merge of #11195 - thvdveld:fix-option-env-ifs-equal-cond, r=Manishearth

  Show description for 7c5095c
  bors

  committed
  7c5095c

  Copy full SHA for 7c5095c

• [`slow_vector_initialization`]: lint `Vec::new()`

  y21

  committed
  541d0c8

  Copy full SHA for 541d0c8

• Allow `Self::cmp(self, other)` as a correct impl

  Centri3

  committed
  a4c367d

  Copy full SHA for a4c367d

• Auto merge of #11188 - Centri3:#11178, r=blyxyas

  Show description for ee8a429
  bors

  committed
  ee8a429

  Copy full SHA for ee8a429

• [`unused_async`]: don't lint if paths reference async fn without call

  y21

  committed
  37b8366

  Copy full SHA for 37b8366

Commits on Jul 21, 2023

• [`inherent_to_string`]: Don't lint `unsafe` or `extern` fns

  Centri3

  committed
  f3f7f63

  Copy full SHA for f3f7f63

• Auto merge of #11205 - Centri3:#11201, r=Manishearth

  Show description for d2c9047
  bors

  committed
  d2c9047

  Copy full SHA for d2c9047

• New lint `absolute_paths`

  Centri3

  committed
  9cf1509

  Copy full SHA for 9cf1509

• Auto merge of #11003 - Centri3:absolute_path, r=Alexendoo,blyxyas

  Show description for 58df1e6
  bors

  committed
  58df1e6

  Copy full SHA for 58df1e6

Commits on Jul 22, 2023

• new lint: redundant_local

  Show description for 008ba2b
  max-niederman

  committed
  008ba2b

  Copy full SHA for 008ba2b

• Auto merge of #10885 - max-niederman:redundant_local, r=Centri3

  Show description for a44dcf8
  bors

  committed
  a44dcf8

  Copy full SHA for a44dcf8

• Make `comparison_to_empty` work on `if let`/`let` chains

  Show description for da93ee8
  Centri3

  committed
  da93ee8

  Copy full SHA for da93ee8

• Remove `LetChain`

  Centri3

  committed
  ae5d391

  Copy full SHA for ae5d391

• new lint `redundant_guards`

  Centri3

  committed
  51b5772

  Copy full SHA for 51b5772

• Auto merge of #10955 - Centri3:redundant_matches_guard, r=Alexendoo,blyxyas

  Show description for df3804a
  bors

  committed
  df3804a

  Copy full SHA for df3804a

• replace HashMap with Vec, use span_lint_hir_and_then

  y21

  committed
  482d5fa

  Copy full SHA for 482d5fa

• Start addressing review comments

  smoelius

  committed
  99202a0

  Copy full SHA for 99202a0

• Auto merge of #11196 - c410-f3r:let-chain, r=xFrednet

  Show description for ea21ed7
  bors

  committed
  ea21ed7

  Copy full SHA for ea21ed7

• Auto merge of #11200 - y21:issue9695, r=Jarcho

  Show description for e8403a8
  bors

  committed
  e8403a8

  Copy full SHA for e8403a8

Commits on Jul 23, 2023

• Auto merge of #11029 - Centri3:empty_slice, r=Jarcho

  Show description for 356768b
  bors

  committed
  356768b

  Copy full SHA for 356768b

• Refactor `dereference.rs`

  Show description for 55dd8a9
  Jarcho

  committed
  55dd8a9

  Copy full SHA for 55dd8a9

• Auto merge of #11184 - GuillaumeGomez:needless_pass_by_ref_mut-async, r=llogiq

  Show description for 43577d5
  bors

  committed
  43577d5

  Copy full SHA for 43577d5

• check that the types are equal in `SpanlessEq::eq_expr`

  y21

  committed
  e975d05

  Copy full SHA for e975d05

• ptr_arg should ignore extern functions

  mrnossiom

  committed
  30d06a8

  Copy full SHA for 30d06a8

• Auto merge of #11166 - Jarcho:expr_use, r=Centri3

  Show description for a4e64ff
  bors

  committed
  a4e64ff

  Copy full SHA for a4e64ff

• Auto merge of #11214 - y21:issue11213, r=Jarcho

  Show description for 5877504
  bors

  committed
  5877504

  Copy full SHA for 5877504

• Auto merge of #10120 - smoelius:or_insert_with, r=blyxyas

  Show description for e4923c2
  bors

  committed
  e4923c2

  Copy full SHA for e4923c2

• ptr lint: check_mut_from_ref is checked independently of the function's ABI

  mrnossiom

  committed
  7b8598d

  Copy full SHA for 7b8598d

Commits on Jul 24, 2023

• Auto merge of #11215 - MrNossiom:master, r=Jarcho

  Show description for a447725
  bors

  committed
  a447725

  Copy full SHA for a447725

• changelog: [`min_ident_chars`]: don't lint const generics

  mrnossiom

  committed
  8298213

  Copy full SHA for 8298213

• Auto merge of #11031 - Centri3:needless_return, r=giraffate

  Show description for 31f3769
  bors

  committed
  31f3769

  Copy full SHA for 31f3769

• Remove Gha status emitter in compile-test

  Alexendoo

  committed
  5c26e82

  Copy full SHA for 5c26e82

• Auto merge of #11218 - MrNossiom:master, r=Manishearth

  Show description for 867e0ec
  bors

  committed
  867e0ec

  Copy full SHA for 867e0ec

Commits on Jul 25, 2023

• Do not lint if used as a `fn`-like argument

  Centri3

  committed
  ef482d1

  Copy full SHA for ef482d1

• Auto merge of #11207 - Centri3:#11182, r=giraffate

  Show description for 43b0e11
  bors

  committed
  43b0e11

  Copy full SHA for 43b0e11

• Auto merge of #11221 - Alexendoo:ui-test-text, r=flip1995

  Show description for d09c8a9
  bors

  committed
  d09c8a9

  Copy full SHA for d09c8a9

• clippy: `env!` invocations can't be b"" literals

  Show description for a147372
  davidtwco

  committed
  a147372

  Copy full SHA for a147372

• bless more

  RalfJung

  committed
  2b16c37

  Copy full SHA for 2b16c37

• Use a builder instead of boolean/option arguments

  oli-obk

  committed
  3fb714d

  Copy full SHA for 3fb714d

• Add a note if the function is behind a cfg

  GuillaumeGomez

  committed
  15de3dd

  Copy full SHA for 15de3dd

• Make everything builtin!

  compiler-errors

  committed
  f20a174

  Copy full SHA for f20a174

• use a dedicated enum for vec initializer

  y21

  committed
  1fe2762

  Copy full SHA for 1fe2762

• Use libtest errors check to better enforce UI testing

  GuillaumeGomez

  committed
  04b710b

  Copy full SHA for 04b710b

• Move `inherits_cfg` function into clippy_utils

  GuillaumeGomez

  committed
  1c9772c

  Copy full SHA for 1c9772c

• simplify looking for `Vec::with_capacity` exprs

  y21

  committed
  c0484b7

  Copy full SHA for c0484b7

• Auto merge of #113393 - compiler-errors:next-solver-unsize-rhs, r=lcnr

  Show description for 2cc44cf
  bors

  committed
  2cc44cf

  Copy full SHA for 2cc44cf

• Fix integration tests

  Show description for c3079a9
  

  flip1995

  authored and

  matthiaskrgr

  committed
  c3079a9

  Copy full SHA for c3079a9

• Rollup merge of #114014 - davidtwco:issue-114010-env-rawstr, r=cjgillot

  Show description for 0f3a149
  matthiaskrgr

  authored
  0f3a149

  Copy full SHA for 0f3a149

• Auto merge of #11198 - y21:issue10938, r=Centri3

  Show description for 70c5798
  bors

  committed
  70c5798

  Copy full SHA for 70c5798

• ci: integration tests: print clippy run output and set LD_LIBRARY_PATH to rustc sysroot

  matthiaskrgr

  committed
  12b63f5

  Copy full SHA for 12b63f5

• Auto merge of #114063 - matthiaskrgr:rollup-c90czu6, r=matthiaskrgr

  Show description for 61e0aac
  bors

  committed
  61e0aac

  Copy full SHA for 61e0aac

• Auto merge of #11226 - GuillaumeGomez:needless-ref-mut-cfg, r=llogiq

  Show description for 2153c0f
  bors

  committed
  2153c0f

  Copy full SHA for 2153c0f

• Add *no merge policy* note via rustbot

  xFrednet

  committed
  5976fda

  Copy full SHA for 5976fda

• New lint [`filter_map_bool_then`]

  Centri3

  committed
  978b1da

  Copy full SHA for 978b1da

• Only lint `Copy` types

  Centri3

  committed
  3235d9d

  Copy full SHA for 3235d9d

• [`arc_with_non_send_sync`]: Check if it's macro-generated

  Centri3

  committed
  90947e9

  Copy full SHA for 90947e9

• Add `sym::iter_mut` + `sym::as_mut_ptr`

  blyxyas

  committed
  0404b6b

  Copy full SHA for 0404b6b

Commits on Jul 26, 2023

• Auto merge of #11115 - Centri3:filter_map_bool_then, r=Jarcho

  Show description for 0fec99f
  bors

  committed
  0fec99f

  Copy full SHA for 0fec99f

• Auto merge of #11233 - Centri3:#11232, r=Jarcho

  Show description for 0d0dbae
  bors

  committed
  0d0dbae

  Copy full SHA for 0d0dbae

• Auto merge of #11231 - xFrednet:00000-merge-no-merge, r=flip1995

  Show description for 80641c0
  bors

  committed
  80641c0

  Copy full SHA for 80641c0

• Auto merge of #11225 - matthiaskrgr:fix_integration_tests2, r=flip1995

  Show description for fc13bf8
  bors

  committed
  fc13bf8

  Copy full SHA for fc13bf8

• Auto merge of #114054 - oli-obk:cleanups, r=estebank

  Show description for ed2ec81
  bors

  committed
  ed2ec81

  Copy full SHA for ed2ec81

• ci: test that we fail CI if we don't find clippy panicking

  matthiaskrgr

  committed
  01b9f9d

  Copy full SHA for 01b9f9d

• Auto merge of #11228 - matthiaskrgr:fix_integration_tests2__with_test, r=flip1995

  Show description for d446378
  bors

  committed
  d446378

  Copy full SHA for d446378

• Now `option_env_unwrap` warns even if a variable isn't set at compile time.

  blyxyas

  committed
  4e1db44

  Copy full SHA for 4e1db44

• Rollup merge of #114070 - blyxyas:iter_mut_symbol, r=oli-obk

  Show description for 8615595
  matthiaskrgr

  authored
  8615595

  Copy full SHA for 8615595

• Unite bless environment variables under `RUSTC_BLESS`

  Show description for 6ca6be6
  tgross35

  committed
  6ca6be6

  Copy full SHA for 6ca6be6

• Add comments + Very minor Refactor

  blyxyas

  committed
  3bfccac

  Copy full SHA for 3bfccac

Commits on Jul 27, 2023

• Auto merge of #113298 - tgross35:update-bless-envs, r=oli-obk

  Show description for 42d3370
  bors

  committed
  42d3370

  Copy full SHA for 42d3370

• new lint: [`readonly_write_lock`]

  y21

  committed
  136339f

  Copy full SHA for 136339f

• make lint description more consistent (writer/reader -> write/read)

  Show description for 205a374
  

  y21

  and

  giraffate

  committed
  205a374

  Copy full SHA for 205a374

• Auto merge of #10759 - blyxyas:unset_opt_env_unwrap, r=flip1995

  Show description for 295bdc0
  bors

  committed
  295bdc0

  Copy full SHA for 295bdc0

Commits on Jul 28, 2023

• pattern match on local usage slice to avoid ICE

  y21

  committed
  5e88003

  Copy full SHA for 5e88003

• Auto merge of #11210 - y21:readonly_write_lock, r=giraffate

  Show description for d3c5b48
  bors

  committed
  d3c5b48

  Copy full SHA for d3c5b48

• Merge remote-tracking branch 'upstream/master' into rustup

  flip1995

  committed
  3d60241

  Copy full SHA for 3d60241

• Bump nightly version -> 2023-07-28

  flip1995

  committed
  65c5afd

  Copy full SHA for 65c5afd

• Auto merge of #11250 - flip1995:rustup, r=flip1995

  Show description for 2973096
  bors

  committed
  2973096

  Copy full SHA for 2973096

Commits on Jul 30, 2023

• Add debug assertions to `implements_trait`

  Show description for 71cc39e
  Jarcho

  committed
  71cc39e

  Copy full SHA for 71cc39e

• Rework `redundant_closure`

  Show description for 4d80a2e
  Jarcho

  committed
  4d80a2e

  Copy full SHA for 4d80a2e

• Don't lint redundant closure for any function call inserted by the compiler.

  Jarcho

  committed
  7423c27

  Copy full SHA for 7423c27

• Auto merge of #8685 - Jarcho:redundant_closure_fixes, r=llogiq

  Show description for 4c2f460
  bors

  committed
  4c2f460

  Copy full SHA for 4c2f460

• Resolve type aliases in `type_certainty`

  Jarcho

  committed
  caf6014

  Copy full SHA for caf6014

• Auto merge of #11258 - Jarcho:ice_11256, r=Centri3

  Show description for c0bdb3d
  bors

  committed
  c0bdb3d

  Copy full SHA for c0bdb3d

• [`unnecessary_find_map`]: look for then_some

  y21

  committed
  008746c

  Copy full SHA for 008746c

• add more tests to unnecessary_find_map and unnecessary_filter_map

  y21

  committed
  be6a103

  Copy full SHA for be6a103

• [arithmetic_side_effects] Fix #11262

  c410-f3r

  committed
  35d434d

  Copy full SHA for 35d434d

• Auto merge of #11261 - y21:issue11260, r=blyxyas

  Show description for 2ab1241
  bors

  committed
  2ab1241

  Copy full SHA for 2ab1241

• Auto merge of #11263 - c410-f3r:let-chain, r=Centri3

  Show description for 5436dba
  bors

  committed
  5436dba

  Copy full SHA for 5436dba

Commits on Jul 31, 2023

• Merge commit '5436dba826191964ac1d0dab534b7eb6d4c878f6' into clippyup

  flip1995

  committed
  53f09d9

  Copy full SHA for 53f09d9