Skip to content

CI: merge msvc cargo and tools jobs #112796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Jun 19, 2023

The x86_64-msvc-cargo and x86_64-msvc-tools jobs both run for ~1 hour, but most of that time is actually spent in building LLVM and rustc, so I want to try merging them.
image

@rustbot
Copy link
Collaborator

rustbot commented Jun 19, 2023

r? @pietroalbini

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jun 19, 2023
@Kobzol
Copy link
Contributor Author

Kobzol commented Jun 19, 2023

The build has finished in 1 hour 13 minutes, so this would cut the duration of the two jobs approximately in half, when combined. https://github.com/rust-lang/rust/actions/runs/5312775017/jobs/9617766087?pr=112796

@Kobzol Kobzol force-pushed the ci-merge-msvc-cargo-tools branch from a15e196 to e115359 Compare June 19, 2023 15:16
@Kobzol Kobzol marked this pull request as ready for review June 19, 2023 15:16
@Kobzol
Copy link
Contributor Author

Kobzol commented Jul 3, 2023

@pietroalbini gentle ping.

@pietroalbini
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 6, 2023

📌 Commit e115359 has been approved by pietroalbini

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 6, 2023
@bors
Copy link
Collaborator

bors commented Jul 7, 2023

⌛ Testing commit e115359 with merge 0608208...

@bors
Copy link
Collaborator

bors commented Jul 7, 2023

☀️ Test successful - checks-actions
Approved by: pietroalbini
Pushing 0608208 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 7, 2023
@bors bors merged commit 0608208 into rust-lang:master Jul 7, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jul 7, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0608208): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.4% [2.3%, 2.4%] 2
Improvements ✅
(primary)
-2.6% [-2.6%, -2.6%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.6% [-2.6%, -2.6%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 658.38s -> 655.999s (-0.36%)

@Kobzol Kobzol deleted the ci-merge-msvc-cargo-tools branch July 7, 2023 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants