Remove the magic deref behavior of newtype structs and enums #11188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also closes #7552. |
|
@cmr I can't find any references to this behavior in the manual. It's true I didn't add any tests for errors since testing for the absence of a feature didn't seem that useful to me. I'll add a new error message that indicates this is a removed feature. |
|
The manual mentioned it for enum variants On Mon, Dec 30, 2013 at 7:08 PM, Brian Anderson [email protected]:
|
|
r=alexcrichton p=1 |
I'm not sure if this was even intentional at this point.
This code was wrong but apparently worked before removing struct deref. I don't know why.
bors
added a commit
that referenced
this pull request
Jan 4, 2014
This removes the feature where newtype structs can be dereferenced like pointers, and likewise where certain enums can be dereferenced (which I imagine nobody realized still existed). This ad-hoc behavior is to be replaced by a more general overloadable dereference trait in the future. I've been nursing this patch for two months and think it's about rebased up to master. @nikomatsakis this makes a bunch of your type checking code noticeably uglier.
chris-morgan
added a commit
to chris-morgan/rust-http
that referenced
this pull request
Jan 5, 2014
nham
pushed a commit
to nham/rust
that referenced
this pull request
May 17, 2015
A built-in feature enabling the dereferencing of newtype structs was removed in PR rust-lang#11188, and this error (E0068) was added at the same time to warn of its removal. It seems to make sense to remove the error now, given that the obsolete feature it is warning about was removed nearly a year and a half ago.
bors
added a commit
that referenced
this pull request
May 17, 2015
A built-in feature enabling the dereferencing of newtype structs was removed in PR #11188, and this error (E0068) was added at the same time to warn of its removal. It seems to make sense to remove the error now, given that the obsolete feature it is warning about was removed nearly a year and a half ago.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 31, 2023
Allow `Self::cmp(self, other)` as a correct impl Fixes rust-lang#11178 Also no longer checks if the method name is *just* cmp, but the path. That was an oversight on my part ^^ r? `@xFrednet` (and `@blyxyas` too!) changelog: [`incorrect_partial_ord_impl_on_ord_type`]: Now allows non-method calls to `cmp` like `Self::cmp(self, other)`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the feature where newtype structs can be dereferenced like pointers, and likewise where certain enums can be dereferenced (which I imagine nobody realized still existed). This ad-hoc behavior is to be replaced by a more general overloadable dereference trait in the future.
I've been nursing this patch for two months and think it's about rebased up to master.
@nikomatsakis this makes a bunch of your type checking code noticeably uglier.