Dogfood CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse in bootstrap

[KittyBorgX]

Fixes #108766

[rustbot]

r? @ozkanonur

(rustbot has picked a reviewer for you, use r? to override)

[albertlarsan68]

The current fix does not fixes the problem, since the registry cache is mainly updated when building bootstrap itself.
Thus the correct fix would be to set it in the Python side of things.

[onur-ozkan]

@rustbot author

[ehuss]

I'm concerned that setting this will prevent users from configuring it themselves. That is, this would prevent it from allowing users to force it to some other value.

The default will be changing in nightly soon. That means that this won't be needed in 6 weeks. Would it be OK to wait until then?

[onur-ozkan]

That means that this won't be needed in 6 weeks. Would it be OK to wait until then?

I think so. But it would be better to hear confirmation from @jyn514

[jyn514]

👍 seems good to me

[rust-log-analyzer]

The job mingw-check-tidy failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Prepare all required actions
Getting action download info
Download action repository 'actions/checkout@v3' (SHA:ac593985615ec2ede58e132d2e21d2b1cbd6127c)
Download action repository 'rust-lang/simpleinfra@master' (SHA:46007752205b5430f5cabe1357251ea7621a9e98)
Complete job name: PR (mingw-check-tidy, true, ubuntu-20.04-xl)
git config --global core.autocrlf false
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  CI_JOB_NAME: mingw-check-tidy
---
Building wheels for collected packages: reuse
  Building wheel for reuse (pyproject.toml): started
  Building wheel for reuse (pyproject.toml): finished with status 'done'
  Created wheel for reuse: filename=reuse-1.1.0-cp310-cp310-manylinux_2_35_x86_64.whl size=180118 sha256=2f37b3a1d0677cd3228b6c9d3baf1ad4a6f9d44f04404765e8544fc47767cbcc
  Stored in directory: /tmp/pip-ephem-wheel-cache-3zioaimv/wheels/c2/3c/b9/1120c2ab4bd82694f7e6f0537dc5b9a085c13e2c69a8d0c76d
Installing collected packages: boolean-py, binaryornot, setuptools, reuse, python-debian, markupsafe, license-expression, jinja2, chardet
  Attempting uninstall: setuptools
    Found existing installation: setuptools 59.6.0
    Not uninstalling setuptools at /usr/lib/python3/dist-packages, outside environment /usr
---
Successfully built ea32bdb0a24b
Successfully tagged rust-ci:latest
Built container sha256:ea32bdb0a24bb5937be78a09a7a7d384211ab0b4ab768bd6bf45cd41fb1a8a33
Uploading finished image to https://ci-caches.rust-lang.org/docker/38eba79578bd6d379f830cfbe873c54dad8d10db1dfcf4fbac8af27e25e93a7ecaa2a7c62028c216d50741db91fde3d04f83489b4d576287b0239d35dee6e197
upload failed: - to s3://rust-lang-ci-sccache2/docker/38eba79578bd6d379f830cfbe873c54dad8d10db1dfcf4fbac8af27e25e93a7ecaa2a7c62028c216d50741db91fde3d04f83489b4d576287b0239d35dee6e197 Unable to locate credentials
[CI_JOB_NAME=mingw-check-tidy]
[CI_JOB_NAME=mingw-check-tidy]
---
   Compiling cargo_metadata v0.14.0
   Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
    Finished release [optimized] target(s) in 16.16s
fmt check
Diff in /checkout/src/bootstrap/builder.rs at line 1888:
         // Try to use a sysroot-relative bindir, in case it was configured absolutely.
         cargo.env("RUSTC_INSTALL_BINDIR", self.config.bindir_relative());
 
-        // Enable sparse protocol while building locally to make compile times faster. 
+        // Enable sparse protocol while building locally to make compile times faster.
         cargo.env("CARGO_REGISTRIES_CRATES_IO_PROTOCOL", "sparse");
 
         self.ci_env.force_coloring_in_ci(&mut cargo);
Running `"/checkout/obj/build/x86_64-unknown-linux-gnu/rustfmt/bin/rustfmt" "--config-path" "/checkout" "--edition" "2021" "--unstable-features" "--skip-children" "--check" "/checkout/src/bootstrap/cache.rs" "/checkout/src/bootstrap/run.rs" "/checkout/src/bootstrap/lib.rs" "/checkout/src/bootstrap/config/tests.rs" "/checkout/src/bootstrap/doc.rs" "/checkout/src/bootstrap/builder.rs" "/checkout/src/bootstrap/sanity.rs" "/checkout/src/bootstrap/download.rs"` failed.
If you're running `tidy`, try again with `--bless`. Or, if you just want to format code, run `./x.py fmt` instead.