Skip to content

Update Clippy #107886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 86 commits into from
Feb 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
86 commits
Select commit Hold shift + click to select a range
ca5f4a1
option_if_let_else: update known problems wording
tgross35 Dec 25, 2022
10c8686
fix overlapping spans for `clippy::uninlined_format_args`
Jan 19, 2023
520814b
Update Clippy for ConstEvalCounter
bryangarza Dec 29, 2022
f9f75e0
Lint `unused_io_amount` with `is_ok` and `is_err`
evantypanski Jan 24, 2023
986f40f
`invalid_regex`: Show full error when string value doesn't match source
Alexendoo Jan 26, 2023
38899d0
replace usages of fn_sig query with bound_fn_sig
kylematsuda Jan 18, 2023
afb586f
change fn_sig query to use EarlyBinder; remove bound_fn_sig query; ad…
kylematsuda Jan 18, 2023
b64a209
Update clippy for restructured format flags fields.
m-ou-se Jan 13, 2023
bcb9052
Auto merge of #107372 - JohnTitor:rollup-zkl2ges, r=JohnTitor
bors Jan 27, 2023
ba6d3e7
Introduce GeneratorWitnessMIR.
cjgillot Oct 1, 2022
5c7a652
Merge commit '1480cea393d0cee195e59949eabdfbcf1230f7f9' into clippyup
flip1995 Jan 27, 2023
997fe0d
Auto merge of #107386 - flip1995:clippyup, r=Manishearth
bors Jan 27, 2023
06e7855
Auto merge of #101692 - cjgillot:generator-lazy-witness, r=oli-obk
bors Jan 28, 2023
e65a7ff
Remove from librustdoc and clippy too
scottmcm Jan 28, 2023
92c4f1e
Take a LocalDefId in hir::Visitor::visit_fn.
cjgillot Jan 22, 2023
3e32533
Remove `HirId -> LocalDefId` map from HIR.
cjgillot Nov 5, 2022
3a68217
Auto merge of #106916 - lukas-code:overlapping-substs, r=estebank
bors Jan 28, 2023
a493717
Rollup merge of #107398 - scottmcm:its-their-funeral, r=dtolnay
matthiaskrgr Jan 28, 2023
75c8179
Auto merge of #107408 - matthiaskrgr:rollup-b5vz2ow, r=matthiaskrgr
bors Jan 28, 2023
79475f5
Auto merge of #107206 - cjgillot:no-h2l-map, r=WaffleLapkin
bors Jan 28, 2023
a0460cf
add COLLAPSIBLE_STR_REPLACE in msrv
koka831 Jan 28, 2023
5a9c4a0
add SEEK_FROM_CURRENT in msrv
koka831 Jan 28, 2023
a05e86f
add SEEK_REWIND in msrv
koka831 Jan 28, 2023
532841f
add UNNECESSARY_LAZY_EVALUATIONS to msrv
koka831 Jan 28, 2023
07a8bf1
add TRANSMUTE_PTR_TO_REF to msrv
koka831 Jan 28, 2023
e65f9f9
add ALMOST_COMPLETE_RANGE to msrv
koka831 Jan 28, 2023
7716d69
fix: add missing dot to AWAIT_HOLDING_INVALID_TYPE
koka831 Jan 28, 2023
fb77b02
add NEEDLESS_BORROW to msrv
koka831 Jan 28, 2023
e791522
add DERIVABLE_IMPLS to msrv
koka831 Jan 28, 2023
25d455b
fix: add missing dot to suppress_restriction_lint_in_const
koka831 Jan 28, 2023
1766532
add MANUAL_IS_ASCII_CHECK to msrv
koka831 Jan 28, 2023
2f4b047
add MANUAL_REM_EUCLID to msrv
koka831 Jan 28, 2023
d87a6bc
add MANUAL_RETAIN to msrv
koka831 Jan 28, 2023
af62bf9
fix key name of MUTABLE_KEY_TYPE
koka831 Jan 28, 2023
17369f3
Auto merge of #106227 - bryangarza:ctfe-limit, r=oli-obk
bors Jan 29, 2023
96c28d1
Auto merge of #10231 - Alexendoo:regex-spans, r=llogiq
bors Jan 29, 2023
4d266d3
needless_range_loop: improve documentation
tylerjw Jan 29, 2023
2fd94a4
prevents `len_without_is_empty` from yielding positive when `len` takes
khayyamsaleem Jan 29, 2023
ecde201
Fix version declared for semicolon_inside_block and semicolon_outside…
Jan 30, 2023
a9e6b12
fix: use correct lint name
koka831 Jan 28, 2023
8fb0041
Auto merge of #10248 - koka831:missing-config, r=xFrednet
bors Jan 30, 2023
3b225e3
Update clippy_lints/src/loops/needless_range_loop.rs
tylerjw Jan 30, 2023
5ed191d
bless
tylerjw Jan 30, 2023
d92070a
Auto merge of #10254 - tylerjw:issue_6929, r=Manishearth
bors Jan 30, 2023
926c5e4
multiple_unsafe_ops_per_block: don't lint in external macros
Niki4tap Jan 30, 2023
173fac0
Auto merge of #10255 - khayyamsaleem:issue_9520, r=Jarcho
bors Jan 30, 2023
d020fd7
Auto merge of #10260 - Niki4tap:external_macro_fp, r=xFrednet
bors Jan 30, 2023
821199c
Modify primary span label for E0308
estebank Jan 3, 2023
c959813
needless_lifetimes: macro test
tylerjw Jan 30, 2023
4fde96c
Test needless_lifetimes within external macro
tylerjw Jan 30, 2023
2432e97
wildcard_enum_match_arm lint takes the enum origin into account
tylerjw Jan 29, 2023
c531b09
Check external before hidden
tylerjw Jan 30, 2023
df7cdf7
Pull the is_external test out of the loop
tylerjw Jan 31, 2023
b4e2b48
Mark uninlined_format_args as pedantic
Manishearth Jan 31, 2023
e1224cd
Auto merge of #10257 - tylerjw:issue_5283, r=flip1995
bors Jan 31, 2023
d227f18
Auto merge of #10225 - evantypanski:et/issue10132, r=flip1995
bors Jan 31, 2023
607e3e8
Auto merge of #10114 - tgross35:option-let-else-wording, r=flip1995
bors Jan 31, 2023
6a8b202
Add machine applicable suggestion for `needless_lifetimes`
Alexendoo Jan 31, 2023
b5a4fa1
Auto merge of #10222 - Alexendoo:needless-lifetime-suggestion, r=flip…
bors Jan 31, 2023
2880dcc
Auto merge of #10265 - Manishearth:uninlined-fmt-pedantic, r=Alexendoo
bors Jan 31, 2023
ef25961
update some dependencies
kadiwa4 Jan 31, 2023
75d7680
Auto merge of #10256 - SylvainDe:master, r=giraffate
bors Feb 1, 2023
588c1ba
Auto merge of #10270 - kadiwa4:update_some_deps, r=flip1995
bors Feb 1, 2023
a2f85de
Auto merge of #10250 - tylerjw:issue_7419, r=xFrednet
bors Feb 1, 2023
f7d59b2
Don't depend on FormatArgsExpn in ManualAssert.
m-ou-se Feb 1, 2023
ecd98ba
Bless tests.
m-ou-se Feb 1, 2023
006a4cc
Auto merge of #10276 - m-ou-se:manual-assert, r=Alexendoo
bors Feb 2, 2023
fba16e2
Add `extra_unused_type_parameters` lint
mkrasnitski Feb 3, 2023
8a98609
Auto merge of #10028 - mkrasnitski:extra_unused_type_parameters, r=fl…
bors Feb 3, 2023
c642cfe
Make `[clippy::dump]` support trait items
xFrednet Feb 4, 2023
5546c82
Negate suggestions when needed in `bool_assert_comparison`
Alexendoo Feb 4, 2023
1fb42da
use span_suggestions to suggest both intents
kartva Feb 4, 2023
46edafe
blessed stderr output
kartva Feb 4, 2023
63a57ee
retain applicability
kartva Feb 4, 2023
2fc1693
split suggestions into two separate suggestions
kartva Feb 6, 2023
b7c3898
bless new output
kartva Feb 7, 2023
3bb6ee5
Auto merge of #10295 - DesmondWillowbrook:diff-format-suspicious-to-o…
bors Feb 8, 2023
fd2d8be
Auto merge of #10293 - Alexendoo:bool-assert-comparison-negation, r=d…
bors Feb 8, 2023
5adeebf
Auto merge of #10292 - xFrednet:0000-support-trait-item-in-dump, r=fl…
bors Feb 9, 2023
7c61b4e
Merge remote-tracking branch 'upstream/master' into rustup
flip1995 Feb 10, 2023
19c07f8
Bump nightly version -> 2023-02-10
flip1995 Feb 10, 2023
a7fecd6
Auto merge of #10313 - flip1995:rustup, r=flip1995
bors Feb 10, 2023
fabada0
Fix CLI of clippy_dev
flip1995 Feb 10, 2023
0f75581
Auto merge of #10314 - flip1995:clippy_dev-cli-fix, r=xFrednet
bors Feb 10, 2023
0be5779
Merge commit '0f7558148c22e53cd4608773b56cdfa50dcdeac3' into clippyup
flip1995 Feb 10, 2023
5566eb4
Update Cargo.lock
flip1995 Feb 10, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions Cargo.lock
Original file line number Diff line number Diff line change
Expand Up @@ -449,7 +449,7 @@ dependencies = [
name = "cargo-miri"
version = "0.1.0"
dependencies = [
"cargo_metadata 0.15.0",
"cargo_metadata 0.15.3",
"directories",
"rustc-build-sysroot",
"rustc-workspace-hack",
Expand Down Expand Up @@ -540,15 +540,16 @@ dependencies = [

[[package]]
name = "cargo_metadata"
version = "0.15.0"
version = "0.15.3"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "3abb7553d5b9b8421c6de7cb02606ff15e0c6eea7d8eadd75ef013fd636bec36"
checksum = "08a1ec454bc3eead8719cb56e15dbbfecdbc14e4b3a3ae4936cc6e31f5fc0d07"
dependencies = [
"camino",
"cargo-platform 0.1.2 (registry+https://github.com/rust-lang/crates.io-index)",
"semver",
"serde",
"serde_json",
"thiserror",
]

[[package]]
Expand Down Expand Up @@ -732,6 +733,7 @@ dependencies = [
name = "clippy"
version = "0.1.69"
dependencies = [
"clap 4.1.4",
"clippy_lints",
"clippy_utils",
"compiletest_rs",
Expand Down Expand Up @@ -762,7 +764,7 @@ name = "clippy_dev"
version = "0.0.1"
dependencies = [
"aho-corasick",
"clap 3.2.20",
"clap 4.1.4",
"indoc",
"itertools",
"opener",
Expand All @@ -774,7 +776,7 @@ dependencies = [
name = "clippy_lints"
version = "0.1.69"
dependencies = [
"cargo_metadata 0.14.0",
"cargo_metadata 0.15.3",
"clippy_utils",
"declare_clippy_lint",
"if_chain",
Expand Down Expand Up @@ -5865,7 +5867,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "54ddb6f31025943e2f9d59237f433711c461a43d9415974c3eb3a4902edc1c1f"
dependencies = [
"bstr 1.0.1",
"cargo_metadata 0.15.0",
"cargo_metadata 0.15.3",
"color-eyre",
"colored",
"crossbeam-channel",
Expand Down
1 change: 1 addition & 0 deletions src/tools/clippy/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4383,6 +4383,7 @@ Released 2018-09-13
[`extend_from_slice`]: https://rust-lang.github.io/rust-clippy/master/index.html#extend_from_slice
[`extend_with_drain`]: https://rust-lang.github.io/rust-clippy/master/index.html#extend_with_drain
[`extra_unused_lifetimes`]: https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[`extra_unused_type_parameters`]: https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
[`fallible_impl_from`]: https://rust-lang.github.io/rust-clippy/master/index.html#fallible_impl_from
[`field_reassign_with_default`]: https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default
[`filetype_is_file`]: https://rust-lang.github.io/rust-clippy/master/index.html#filetype_is_file
Expand Down
1 change: 1 addition & 0 deletions src/tools/clippy/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ filetime = "0.2"
rustc-workspace-hack = "1.0"

# UI test dependencies
clap = { version = "4.1.4", features = ["derive"] }
clippy_utils = { path = "clippy_utils" }
derive-new = "0.5"
if_chain = "1.0"
Expand Down
2 changes: 1 addition & 1 deletion src/tools/clippy/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

A collection of lints to catch common mistakes and improve your [Rust](https://github.com/rust-lang/rust) code.

[There are over 550 lints included in this crate!](https://rust-lang.github.io/rust-clippy/master/index.html)
[There are over 600 lints included in this crate!](https://rust-lang.github.io/rust-clippy/master/index.html)

Lints are divided into categories, each with a default [lint level](https://doc.rust-lang.org/rustc/lints/levels.html).
You can choose how much Clippy is supposed to ~~annoy~~ help you by changing the lint level by category.
Expand Down
2 changes: 1 addition & 1 deletion src/tools/clippy/book/src/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
A collection of lints to catch common mistakes and improve your
[Rust](https://github.com/rust-lang/rust) code.

[There are over 550 lints included in this crate!](https://rust-lang.github.io/rust-clippy/master/index.html)
[There are over 600 lints included in this crate!](https://rust-lang.github.io/rust-clippy/master/index.html)

Lints are divided into categories, each with a default [lint
level](https://doc.rust-lang.org/rustc/lints/levels.html). You can choose how
Expand Down
26 changes: 23 additions & 3 deletions src/tools/clippy/book/src/lint_configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ Please use that command to update the file and do not edit it by hand.
| [allowed-scripts](#allowed-scripts) | `["Latin"]` |
| [enable-raw-pointer-heuristic-for-send](#enable-raw-pointer-heuristic-for-send) | `true` |
| [max-suggested-slice-pattern-length](#max-suggested-slice-pattern-length) | `3` |
| [await-holding-invalid-types](#await-holding-invalid-types) | `[]` |
| [max-include-file-size](#max-include-file-size) | `1000000` |
| [allow-expect-in-tests](#allow-expect-in-tests) | `false` |
| [allow-unwrap-in-tests](#allow-unwrap-in-tests) | `false` |
Expand Down Expand Up @@ -167,6 +168,17 @@ The minimum rust version that the project supports
* [manual_clamp](https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp)
* [manual_let_else](https://rust-lang.github.io/rust-clippy/master/index.html#manual_let_else)
* [unchecked_duration_subtraction](https://rust-lang.github.io/rust-clippy/master/index.html#unchecked_duration_subtraction)
* [collapsible_str_replace](https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace)
* [seek_from_current](https://rust-lang.github.io/rust-clippy/master/index.html#seek_from_current)
* [seek_rewind](https://rust-lang.github.io/rust-clippy/master/index.html#seek_rewind)
* [unnecessary_lazy_evaluations](https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations)
* [transmute_ptr_to_ref](https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref)
* [almost_complete_range](https://rust-lang.github.io/rust-clippy/master/index.html#almost_complete_range)
* [needless_borrow](https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow)
* [derivable_impls](https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls)
* [manual_is_ascii_check](https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_ascii_check)
* [manual_rem_euclid](https://rust-lang.github.io/rust-clippy/master/index.html#manual_rem_euclid)
* [manual_retain](https://rust-lang.github.io/rust-clippy/master/index.html#manual_retain)


### cognitive-complexity-threshold
Expand Down Expand Up @@ -279,7 +291,7 @@ The minimum size (in bytes) to consider a type for passing by reference instead

**Default Value:** `256` (`u64`)

* [large_type_pass_by_move](https://rust-lang.github.io/rust-clippy/master/index.html#large_type_pass_by_move)
* [large_types_passed_by_value](https://rust-lang.github.io/rust-clippy/master/index.html#large_types_passed_by_value)


### too-many-lines-threshold
Expand Down Expand Up @@ -442,6 +454,14 @@ For example, `[_, _, _, e, ..]` is a slice pattern with 4 elements.
* [index_refutable_slice](https://rust-lang.github.io/rust-clippy/master/index.html#index_refutable_slice)


### await-holding-invalid-types


**Default Value:** `[]` (`Vec<crate::utils::conf::DisallowedPath>`)

* [await_holding_invalid_type](https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_invalid_type)


### max-include-file-size
The maximum size of a file included via `include_bytes!()` or `include_str!()`, in bytes

Expand Down Expand Up @@ -497,7 +517,7 @@ for the generic parameters for determining interior mutability

**Default Value:** `["bytes::Bytes"]` (`Vec<String>`)

* [mutable_key](https://rust-lang.github.io/rust-clippy/master/index.html#mutable_key)
* [mutable_key_type](https://rust-lang.github.io/rust-clippy/master/index.html#mutable_key_type)


### allow-mixed-uninlined-format-args
Expand All @@ -509,7 +529,7 @@ Whether to allow mixed uninlined format args, e.g. `format!("{} {}", a, foo.bar)


### suppress-restriction-lint-in-const
In same
Whether to suppress a restriction lint in constant code. In same
cases the restructured operation might not be unavoidable, as the
suggested counterparts are unavailable in constant code. This
configuration will cause restriction lints to trigger even
Expand Down
2 changes: 1 addition & 1 deletion src/tools/clippy/clippy_dev/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ edition = "2021"

[dependencies]
aho-corasick = "0.7"
clap = "3.2"
clap = "4.1.4"
indoc = "1.0"
itertools = "0.10.1"
opener = "0.5"
Expand Down
Loading