Skip to content

Use the native tls implementation on android #10687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2013

Conversation

alexcrichton
Copy link
Member

Turns out android doesn't support LLVM's thread_local attribute and accompanying
implementation.

Closes #10686

@yichoi
Copy link
Contributor

yichoi commented Nov 27, 2013

@alexcrichton could you check it again ?

/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-nopt-t/build/src/libstd/rt/local.rs:135:12: 135:35 error: unresolved name `local_ptr::init_tls_key`.
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-nopt-t/build/src/libstd/rt/local.rs:135             local_ptr::init_tls_key();
                                                                                                          ^~~~~~~~~~~~~~~~~~~~~~~
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-nopt-t/build/src/libstd/rt/local.rs:147:12: 147:35 error: unresolved name `local_ptr::init_tls_key`.
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-nopt-t/build/src/libstd/rt/local.rs:147             local_ptr::init_tls_key();
                                                                                                          ^~~~~~~~~~~~~~~~~~~~~~~
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-nopt-t/build/src/libstd/rt/local.rs:164:12: 164:35 error: unresolved name `local_ptr::init_tls_key`.
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-nopt-t/build/src/libstd/rt/local.rs:164             local_ptr::init_tls_key();
                                                                                                          ^~~~~~~~~~~~~~~~~~~~~~~
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-nopt-t/build/src/libstd/rt/local.rs:180:12: 180:35 error: unresolved name `local_ptr::init_tls_key`.
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-nopt-t/build/src/libstd/rt/local.rs:180             local_ptr::init_tls_key();
                                                                                                          ^~~~~~~~~~~~~~~~~~~~~~~
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-nopt-t/build/src/libstd/rt/local_ptr.rs:269:28: 269:74 error: unresolved name
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-nopt-t/build/src/libstd/rt/local_ptr.rs:269             cast::transmute(realstd::rt::shouldnt_be_public::maybe_tls_key())
                                                                                                                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-nopt-t/build/src/libstd/rt/local_ptr.rs:269:28: 269:74 error: use of undeclared module `realstd::rt::shouldnt_be_public`
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-nopt-t/build/src/libstd/rt/local_ptr.rs:269             cast::transmute(realstd::rt::shouldnt_be_public::maybe_tls_key())
                                                                                                                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-nopt-t/build/src/libstd/rt/local_ptr.rs:269:28: 269:74 error: unresolved name `realstd::rt::shouldnt_be_public::maybe_tls_key`.
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-nopt-t/build/src/libstd/rt/local_ptr.rs:269             cast::transmute(realstd::rt::shouldnt_be_public::maybe_tls_key())
                                                                                                                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
error: aborting due to 7 previous errors

Turns out android doesn't support LLVM's thread_local attribute and accompanying
implementation.

Closes rust-lang#10686
bors added a commit that referenced this pull request Nov 28, 2013
Turns out android doesn't support LLVM's thread_local attribute and accompanying
implementation.

Closes #10686
@bors bors closed this Nov 28, 2013
@bors bors merged commit 1686bfa into rust-lang:master Nov 28, 2013
@alexcrichton alexcrichton deleted the issue-10686 branch November 28, 2013 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rust can not make binary for android
3 participants