Reintroduce -Zchalk with error recommending -Ztrait-solver=chalk
#106514
Conversation
|
r? @nagisa (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
compiler-errors
force-pushed
the
reintroduce-chalk-flag-w-err
branch
from
a5ce2da to
47ecdce
Compare
compiler-errors
force-pushed
the
reintroduce-chalk-flag-w-err
branch
from
47ecdce to
53e46db
Compare
There was a problem hiding this comment.
Is the full refactor like this truly necessary? Could there been a simple if opts.chalk { output_the_diagnostic() } to start?
I would rather the big refactor be discussed separately as a non-functional-change, rather than bundled with useful changes (like -Zchalk). Clearly our options parsing code is now quite crufty and it isn’t clear to me if adding more complexity to it is a good tradeoff at the moment.
(also really sorry for the late review!)
| }, | ||
| Err(ParseError::Removed(in_favor_of)) => early_error( | ||
| error_format, | ||
| &format!("{outputname} option `{key}` removed in favor of `{in_favor_of}`"), |
There was a problem hiding this comment.
Won’t this make the diagnostic here non-translatable? Do we want it to be translatable?
There was a problem hiding this comment.
It's just as untranslatable as the existing error message above it. And the inputs are just options, so I don't see why this couldn't be migrated
Yeah, I could probably find somewhere to shove that. I'll put it up as a separate PR, probably much shorter. |
Adds
-Zchalkback with a helpful error message:cc #106385