disable strict-provenance-violating doctests in Miri #104710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
RalfJung
force-pushed
the
doc-strict-provenance
branch
from
208c6ae to
2802eae
Compare
|
Seems good to me. @bors r+ rollup |
|
📌 Commit 2802eae9baef00c5082d58c35be3fec3b3a77253 has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
RalfJung
force-pushed
the
doc-strict-provenance
branch
from
2802eae to
3a95e12
Compare
|
@bors r=thomcc |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 22, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#104295 (Check generics parity before collecting return-position `impl Trait`s in trait) - rust-lang#104464 (Reduce exceptions overallocation on non Windows x86_64) - rust-lang#104615 (Create def_id for async fns during lowering) - rust-lang#104669 (Only declare bindings for if-let guards once per arm) - rust-lang#104701 (Remove a lifetime resolution hack from `compare_predicate_entailment`) - rust-lang#104710 (disable strict-provenance-violating doctests in Miri) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of these are on deprecated unstable functions anyway. This lets us run the remaining doctests with
-Zmiri-strict-provenance, which I think is a win.r? @thomcc