Promote once-fns to a #[feature] directive #9755
Labels
E-easy
Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Comments
bors
added a commit
that referenced
this issue
Oct 17, 2013
…ive, r=alexcrichton Hello, First time rust contributor here, please let me know if I need to sort out the contribution agreement for this. I picked issue #9755 to dip my toe in the water, this pull request isn't quite complete though as I have not updated the documentation. The reason for this is that I haven't tracked down why this feature is gated so I don't feel I can write a justification of the same quality as the other features have been documented. If someone would like to explain or point me at a mail thread I am happy to update with this change. Hopefully I have understood the process of converting the old flag into a directive correctly. Also just to call out what I am sure if a known quirk when adding feature directives, you can't build this code unless you have a snapshot of the compiler which knows about the feature directive. Chicken and the egg. I split the change into two commits, the first should be able to build a snapshot that can compile the second.
|
Closed by #9863. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this issue
Nov 21, 2022
…shearth Warn when `clippy::restriction` is enabled via the command line Currently it catches `#![warn(clippy::restriction)]`, it'll now catch `-W clippy::restriction` from the CLI. Also tweaks the message slightly changelog: [`blanket_clippy_restriction_lints`]: Warn when `clippy::restriction` is enabled via the command line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now once-fns are hidden behind a
-Zflag, but now that we have#[feature]directives we should use them instead.This should involve removal of the
-Zflag code, modifyingfeature_gate.rsand updatingdoc/rust.mdwith the new feature (and why it's a gated feature, not on-by-default)The text was updated successfully, but these errors were encountered: