Skip to content

rustpkg tests shouldn't compare modification times #9441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
catamorphism opened this issue Sep 23, 2013 · 4 comments
Closed

rustpkg tests shouldn't compare modification times #9441

catamorphism opened this issue Sep 23, 2013 · 4 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc

Comments

@catamorphism
Copy link
Contributor

The tests shouldn't compare the results of mtimes from util::datestamp. I fixed one of the tests, but others are failing now too, and then my fix for it failed on the linux bot. I'm investigating.

@ghost ghost assigned catamorphism Sep 23, 2013
@catamorphism
Copy link
Contributor Author

I'm working on this, but the scratch directory on the linux bot that I was working out of mysteriously decided to rebuild LLVM again, and I have to leave for the day, so I'll get to it tomorrow.

@catamorphism
Copy link
Contributor Author

I'm about to check in a fix that will unignore all the tests except for test_rebuild_when_needed. That one still fails on Linux for some reason. When it can be un-ignored on Linux, this bug can be closed.

catamorphism added a commit that referenced this issue Oct 2, 2013
Instead of scrutinizing modification times in rustpkg tests,
change output files to be read-only and detect attempts to write
to them (hack suggested by Jack). This avoids time granularity problems.

As part of this change, I discovered that some dependencies weren't
getting written correctly (involving built executables and library
files), so this patch fixes that too.

This partly addresses #9441, but one test (test_rebuild_when_needed)
is still ignored on Linux.
catamorphism added a commit that referenced this issue Oct 4, 2013
Instead of scrutinizing modification times in rustpkg tests,
change output files to be read-only and detect attempts to write
to them (hack suggested by Jack). This avoids time granularity problems.

As part of this change, I discovered that some dependencies weren't
getting written correctly (involving built executables and library
files), so this patch fixes that too.

This partly addresses #9441, but one test (test_rebuild_when_needed)
is still ignored on Linux.
@catamorphism
Copy link
Contributor Author

I changed the tests so that they set the output files to read-only in order to check for unwanted rebuilding. The problem is that on Linux, the linker will silently overwrite a read-only file. I thought I had a fix for this (checking in rustc, before invoking the linker, that the output file doesn't exist as a read-only file already) but that failed on the try bots, too, and since I don't have VPN access, I can't log into the bot to experiment right now.

catamorphism added a commit to catamorphism/rust that referenced this issue Oct 17, 2013
Instead of scrutinizing modification times in rustpkg tests,
change output files to be read-only and detect attempts to write
to them (hack suggested by Jack). This avoids time granularity problems.

As part of this change, I discovered that some dependencies weren't
getting written correctly (involving built executables and library
files), so this patch fixes that too.

This partly addresses rust-lang#9441, but one test (test_rebuild_when_needed)
is still ignored on Linux.
catamorphism added a commit that referenced this issue Oct 18, 2013
Instead of scrutinizing modification times in rustpkg tests,
change output files to be read-only and detect attempts to write
to them (hack suggested by Jack). This avoids time granularity problems.

As part of this change, I discovered that some dependencies weren't
getting written correctly (involving built executables and library
files), so this patch fixes that too.

This partly addresses #9441, but one test (test_rebuild_when_needed)
is still ignored on Linux.
catamorphism added a commit to catamorphism/rust that referenced this issue Oct 19, 2013
Instead of scrutinizing modification times in rustpkg tests,
change output files to be read-only and detect attempts to write
to them (hack suggested by Jack). This avoids time granularity problems.

As part of this change, I discovered that some dependencies weren't
getting written correctly (involving built executables and library
files), so this patch fixes that too.

This partly addresses rust-lang#9441, but one test (test_rebuild_when_needed)
is still ignored on Linux.
@catamorphism
Copy link
Contributor Author

#9437 fixed this.

@catamorphism catamorphism removed their assignment Jun 16, 2014
flip1995 pushed a commit to flip1995/rust that referenced this issue Sep 9, 2022
Fix hang in `vec_init_then_push`

fixes rust-lang#9433
changelog: Fix infinite loop in `vec_init_then_push`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc
Projects
None yet
Development

No branches or pull requests

1 participant