rustpkg tests shouldn't compare modification times #9441
Comments
ghost
assigned 
|
I'm working on this, but the scratch directory on the linux bot that I was working out of mysteriously decided to rebuild LLVM again, and I have to leave for the day, so I'll get to it tomorrow. |
|
I'm about to check in a fix that will unignore all the tests except for |
Instead of scrutinizing modification times in rustpkg tests, change output files to be read-only and detect attempts to write to them (hack suggested by Jack). This avoids time granularity problems. As part of this change, I discovered that some dependencies weren't getting written correctly (involving built executables and library files), so this patch fixes that too. This partly addresses #9441, but one test (test_rebuild_when_needed) is still ignored on Linux.
Instead of scrutinizing modification times in rustpkg tests, change output files to be read-only and detect attempts to write to them (hack suggested by Jack). This avoids time granularity problems. As part of this change, I discovered that some dependencies weren't getting written correctly (involving built executables and library files), so this patch fixes that too. This partly addresses #9441, but one test (test_rebuild_when_needed) is still ignored on Linux.
|
I changed the tests so that they set the output files to read-only in order to check for unwanted rebuilding. The problem is that on Linux, the linker will silently overwrite a read-only file. I thought I had a fix for this (checking in rustc, before invoking the linker, that the output file doesn't exist as a read-only file already) but that failed on the try bots, too, and since I don't have VPN access, I can't log into the bot to experiment right now. |
Instead of scrutinizing modification times in rustpkg tests, change output files to be read-only and detect attempts to write to them (hack suggested by Jack). This avoids time granularity problems. As part of this change, I discovered that some dependencies weren't getting written correctly (involving built executables and library files), so this patch fixes that too. This partly addresses rust-lang#9441, but one test (test_rebuild_when_needed) is still ignored on Linux.
Instead of scrutinizing modification times in rustpkg tests, change output files to be read-only and detect attempts to write to them (hack suggested by Jack). This avoids time granularity problems. As part of this change, I discovered that some dependencies weren't getting written correctly (involving built executables and library files), so this patch fixes that too. This partly addresses #9441, but one test (test_rebuild_when_needed) is still ignored on Linux.
Instead of scrutinizing modification times in rustpkg tests, change output files to be read-only and detect attempts to write to them (hack suggested by Jack). This avoids time granularity problems. As part of this change, I discovered that some dependencies weren't getting written correctly (involving built executables and library files), so this patch fixes that too. This partly addresses rust-lang#9441, but one test (test_rebuild_when_needed) is still ignored on Linux.
|
#9437 fixed this. |
Fix hang in `vec_init_then_push` fixes rust-lang#9433 changelog: Fix infinite loop in `vec_init_then_push`
The tests shouldn't compare the results of mtimes from
util::datestamp. I fixed one of the tests, but others are failing now too, and then my fix for it failed on the linux bot. I'm investigating.The text was updated successfully, but these errors were encountered: